[GitHub] spark pull request #22152: [SPARK-25159][SQL] json schema inference should o...

2018-08-22 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22152#discussion_r212183703 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala --- @@ -69,10 +70,17 @@ private[sql] object

[GitHub] spark pull request #22152: [SPARK-25159][SQL] json schema inference should o...

2018-08-22 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22152#discussion_r211860311 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala --- @@ -69,10 +70,17 @@ private[sql] object

[GitHub] spark pull request #22152: [SPARK-25159][SQL] json schema inference should o...

2018-08-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22152 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22152: [SPARK-25159][SQL] json schema inference should o...

2018-08-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22152#discussion_r211815985 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala --- @@ -69,10 +70,17 @@ private[sql] object

[GitHub] spark pull request #22152: [SPARK-25159][SQL] json schema inference should o...

2018-08-21 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22152#discussion_r211626457 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala --- @@ -2528,4 +2529,27 @@ class DataFrameSuite extends QueryTest with

[GitHub] spark pull request #22152: [SPARK-25159][SQL] json schema inference should o...

2018-08-21 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22152#discussion_r211621168 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala --- @@ -69,10 +70,17 @@ private[sql] object

[GitHub] spark pull request #22152: [SPARK-25159][SQL] json schema inference should o...

2018-08-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22152#discussion_r211607005 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala --- @@ -69,10 +70,17 @@ private[sql] object

[GitHub] spark pull request #22152: [SPARK-25159][SQL] json schema inference should o...

2018-08-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22152#discussion_r211599957 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala --- @@ -69,10 +70,17 @@ private[sql] object JsonInferSchema

[GitHub] spark pull request #22152: [SPARK-25159][SQL] json schema inference should o...

2018-08-21 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22152#discussion_r211584402 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -116,16 +129,24 @@ object SQLConf { if (TaskContext.get

[GitHub] spark pull request #22152: [SPARK-25159][SQL] json schema inference should o...

2018-08-21 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22152#discussion_r211585144 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala --- @@ -69,10 +70,17 @@ private[sql] object

[GitHub] spark pull request #22152: [SPARK-25159][SQL] json schema inference should o...

2018-08-21 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22152#discussion_r211496317 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala --- @@ -69,10 +70,17 @@ private[sql] object

[GitHub] spark pull request #22152: [SPARK-25159][SQL] json schema inference should o...

2018-08-20 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22152#discussion_r211189624 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala --- @@ -69,10 +70,17 @@ private[sql] object JsonInferSchema

[GitHub] spark pull request #22152: [SPARK-25159][SQL] json schema inference should o...

2018-08-20 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/22152 [SPARK-25159][SQL] json schema inference should only trigger one job ## What changes were proposed in this pull request? This fixes a perf regression caused by