[GitHub] spark pull request #22161: [SPARK-25167][SPARKR][TEST][MINOR] Minor fixes fo...

2018-08-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22161 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22161: [SPARK-25167][SPARKR][TEST][MINOR] Minor fixes fo...

2018-08-22 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22161#discussion_r212168906 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -3613,11 +3613,11 @@ test_that("Collect on DataFrame when NAs exists at the top of a timestamp

[GitHub] spark pull request #22161: [SPARK-25167][SPARKR][TEST][MINOR] Minor fixes fo...

2018-08-21 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22161#discussion_r211541767 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -3640,17 +3640,18 @@ test_that("catalog APIs, listTables, listColumns, listFunctions", {

[GitHub] spark pull request #22161: [SPARK-25167][SPARKR][TEST][MINOR] Minor fixes fo...

2018-08-21 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22161#discussion_r211490349 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -3613,11 +3613,11 @@ test_that("Collect on DataFrame when NAs exists at the top of a timestamp

[GitHub] spark pull request #22161: [SPARK-25167][SPARKR][TEST][MINOR] Minor fixes fo...

2018-08-21 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22161#discussion_r211487544 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -3613,11 +3613,11 @@ test_that("Collect on DataFrame when NAs exists at the top of a timestamp