[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-09-07 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r216119774 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -969,6 +969,20 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-09-07 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r216119706 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -969,6 +969,20 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-09-07 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r216119703 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -969,6 +969,20 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-09-07 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r216119684 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1950,6 +1962,11 @@ class SQLConf extends Serializable with Logging

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-09-07 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r216119676 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1950,6 +1962,11 @@ class SQLConf extends Serializable with Logging

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-09-07 Thread AndrewKL
Github user AndrewKL commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r216045605 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -969,6 +969,22 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-09-06 Thread AndrewKL
Github user AndrewKL commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r215618109 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -969,6 +969,22 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-09-06 Thread AndrewKL
Github user AndrewKL commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r215617996 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -815,6 +815,24 @@ class Dataset[T] private[sql](

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-09-06 Thread AndrewKL
Github user AndrewKL commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r215617577 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -815,6 +815,24 @@ class Dataset[T] private[sql](

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-09-06 Thread AndrewKL
Github user AndrewKL commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r215617515 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -815,6 +815,24 @@ class Dataset[T] private[sql](

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-08-27 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r213158510 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -815,6 +815,24 @@ class Dataset[T] private[sql](

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-08-27 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r213158056 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -969,6 +969,22 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-08-27 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r213157406 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -815,6 +815,24 @@ class Dataset[T] private[sql](

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-08-27 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r213026874 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -815,6 +815,24 @@ class Dataset[T] private[sql](

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-08-27 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r213010807 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -815,6 +815,24 @@ class Dataset[T] private[sql](

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-08-27 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r213010706 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -815,6 +815,24 @@ class Dataset[T] private[sql](

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-08-27 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r213010879 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -815,6 +815,24 @@ class Dataset[T] private[sql](

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-08-27 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r213010672 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -815,6 +815,24 @@ class Dataset[T] private[sql](

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-08-26 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r212832846 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -969,6 +969,22 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-08-26 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r212832850 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -969,6 +969,22 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-08-26 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r212832795 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -969,6 +969,22 @@ class DatasetSuite extends QueryTest with

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-08-26 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r212832804 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -815,6 +815,24 @@ class Dataset[T] private[sql](

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-08-26 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r212832734 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -815,6 +815,24 @@ class Dataset[T] private[sql](

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-08-25 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r212801959 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala --- @@ -815,6 +815,24 @@ class Dataset[T] private[sql](

[GitHub] spark pull request #22162: [spark-24442][SQL] Added parameters to control th...

2018-08-20 Thread AndrewKL
GitHub user AndrewKL opened a pull request: https://github.com/apache/spark/pull/22162 [spark-24442][SQL] Added parameters to control the default number of … …records shown and the truncate length when a user calls .show() on a dataframe ## What changes were proposed