[GitHub] spark pull request #22246: [SPARK-25235] [SHELL] Merge the REPL code in Scal...

2018-08-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22246 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22246: [SPARK-25235] [SHELL] Merge the REPL code in Scal...

2018-08-28 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22246#discussion_r213492833 --- Diff: repl/src/main/scala/org/apache/spark/repl/SparkILoop.scala --- @@ -43,10 +44,26 @@ class SparkILoop(in0: Option[BufferedReader], out:

[GitHub] spark pull request #22246: [SPARK-25235] [SHELL] Merge the REPL code in Scal...

2018-08-28 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/22246#discussion_r213429435 --- Diff: repl/src/main/scala/org/apache/spark/repl/SparkILoop.scala --- @@ -43,10 +44,26 @@ class SparkILoop(in0: Option[BufferedReader], out:

[GitHub] spark pull request #22246: [SPARK-25235] [SHELL] Merge the REPL code in Scal...

2018-08-27 Thread dbtsai
GitHub user dbtsai opened a pull request: https://github.com/apache/spark/pull/22246 [SPARK-25235] [SHELL] Merge the REPL code in Scala 2.11 and 2.12 branches ## What changes were proposed in this pull request? Using some reflection tricks to merge Scala 2.11 and 2.12