Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22399
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user Fokko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r219480345
--- Diff:
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/CLIService.java
---
@@ -146,16 +146,11 @@ public UserGroupInformation getHttpUGI()
Github user Fokko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r218678719
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/ChunkFetchIntegrationSuite.java
---
@@ -143,37 +143,38 @@ public void
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r218635691
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/ChunkFetchIntegrationSuite.java
---
@@ -143,37 +143,38 @@ public void
Github user Fokko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r218532105
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/ChunkFetchIntegrationSuite.java
---
@@ -143,37 +143,38 @@ public void
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r218121426
--- Diff:
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/CLIService.java
---
@@ -146,16 +146,11 @@ public UserGroupInformation getHttpUGI()
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r218117766
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/ChunkFetchIntegrationSuite.java
---
@@ -143,37 +143,38 @@ public void
Github user Fokko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r218078332
--- Diff:
sql/catalyst/src/test/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatchSuite.java
---
@@ -356,49 +335,45 @@ public void
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r217036427
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleIntegrationSuite.java
---
@@ -133,37 +133,37 @@ private
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216968925
--- Diff:
sql/catalyst/src/test/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatchSuite.java
---
@@ -321,20 +302,18 @@ public void
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216968827
--- Diff:
sql/catalyst/src/test/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatchSuite.java
---
@@ -293,18 +276,16 @@ public void
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216968497
--- Diff:
sql/catalyst/src/test/java/org/apache/spark/sql/catalyst/expressions/RowBasedKeyValueBatchSuite.java
---
@@ -356,49 +335,45 @@ public void
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216968270
--- Diff:
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/CLIService.java
---
@@ -146,16 +146,11 @@ public UserGroupInformation getHttpUGI()
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216962458
--- Diff: core/src/test/java/test/org/apache/spark/JavaAPISuite.java ---
@@ -997,10 +997,10 @@ public void binaryFiles() throws Exception {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216962519
--- Diff: core/src/test/java/test/org/apache/spark/JavaAPISuite.java ---
@@ -1018,10 +1018,10 @@ public void binaryFilesCaching() throws Exception {
Github user Fokko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216962424
--- Diff: core/src/test/java/org/apache/spark/JavaJdbcRDDSuite.java ---
@@ -39,30 +39,27 @@ public void setUp() throws ClassNotFoundException,
SQLException {
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216962247
--- Diff:
core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java ---
@@ -181,42 +181,43 @@ private void writeSortedFile(boolean
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216960624
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolverSuite.java
---
@@ -98,19 +98,19 @@ public void
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216960499
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolverSuite.java
---
@@ -98,19 +98,19 @@ public void
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216928976
--- Diff: core/src/test/java/org/apache/spark/JavaJdbcRDDSuite.java ---
@@ -39,30 +39,27 @@ public void setUp() throws ClassNotFoundException,
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216928812
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleIntegrationSuite.java
---
@@ -133,37 +133,37 @@ private
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216929186
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/sasl/SaslIntegrationSuite.java
---
@@ -21,6 +21,7 @@
import
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216928860
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleSecuritySuite.java
---
@@ -96,14 +96,14 @@ private void
Github user Fokko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216922969
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractAppHandle.java ---
@@ -72,11 +74,7 @@ public void stop() {
@Override
public
Github user Fokko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216921874
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleIntegrationSuite.java
---
@@ -133,37 +133,37 @@ private
Github user Fokko commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216917780
--- Diff:
common/kvstore/src/test/java/org/apache/spark/util/kvstore/DBIteratorSuite.java
---
@@ -383,7 +383,7 @@ public void testRefWithIntNaturalKey()
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216896517
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractAppHandle.java ---
@@ -72,11 +74,7 @@ public void stop() {
@Override
public
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216882375
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/AbstractAppHandle.java ---
@@ -72,11 +74,7 @@ public void stop() {
@Override
public
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216881904
--- Diff:
common/network-common/src/test/java/org/apache/spark/network/ChunkFetchIntegrationSuite.java
---
@@ -143,61 +143,62 @@ public void
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216882060
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleIntegrationSuite.java
---
@@ -133,37 +133,37 @@ private
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216882288
--- Diff:
core/src/test/java/org/apache/spark/launcher/SparkLauncherSuite.java ---
@@ -18,12 +18,7 @@
package org.apache.spark.launcher;
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216882035
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolverSuite.java
---
@@ -98,19 +98,19 @@ public void
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216881870
--- Diff:
common/kvstore/src/test/java/org/apache/spark/util/kvstore/DBIteratorSuite.java
---
@@ -383,7 +383,7 @@ public void testRefWithIntNaturalKey()
Github user TomaszGaweda commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216824283
--- Diff:
common/kvstore/src/test/java/org/apache/spark/util/kvstore/DBIteratorSuite.java
---
@@ -383,7 +383,7 @@ public void
GitHub user Fokko opened a pull request:
https://github.com/apache/spark/pull/22399
[SPARK-25408] Move to mode ideomatic Java8
While working on another PR, I noticed that there is quite some legacy Java
in there that can be beautified. For example the use og features from Java8,
35 matches
Mail list logo
