[GitHub] spark pull request #22522: [SPARK-25510][TEST] Create new trait replace Benc...

2018-10-01 Thread wangyum
Github user wangyum closed the pull request at: https://github.com/apache/spark/pull/22522 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22522: [SPARK-25510][TEST] Create new trait replace Benc...

2018-09-28 Thread wangyum
GitHub user wangyum reopened a pull request: https://github.com/apache/spark/pull/22522 [SPARK-25510][TEST] Create new trait replace BenchmarkWithCodegen ## What changes were proposed in this pull request? We need create a new trait to replace `BenchmarkWithCodegen` as

[GitHub] spark pull request #22522: [SPARK-25510][TEST] Create new trait replace Benc...

2018-09-22 Thread wangyum
Github user wangyum closed the pull request at: https://github.com/apache/spark/pull/22522 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22522: [SPARK-25510][TEST] Create new trait replace Benc...

2018-09-22 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/22522#discussion_r219674900 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/RunBenchmarkWithCodegen.scala --- @@ -0,0 +1,52 @@ +/* + * Licensed to

[GitHub] spark pull request #22522: [SPARK-25510][TEST] Create new trait replace Benc...

2018-09-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22522#discussion_r219672131 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/RunBenchmarkWithCodegen.scala --- @@ -0,0 +1,52 @@ +/* + * Licensed

[GitHub] spark pull request #22522: [SPARK-25510][TEST] Create new trait replace Benc...

2018-09-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22522#discussion_r219672121 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/RunBenchmarkWithCodegen.scala --- @@ -0,0 +1,52 @@ +/* + * Licensed

[GitHub] spark pull request #22522: [SPARK-25510][TEST] Create new trait replace Benc...

2018-09-21 Thread wangyum
GitHub user wangyum opened a pull request: https://github.com/apache/spark/pull/22522 [SPARK-25510][TEST] Create new trait replace BenchmarkWithCodegen ## What changes were proposed in this pull request? We need create a new trait to replace `BenchmarkWithCodegen` as