[GitHub] spark pull request #22581: [SPARK-25565][BUILD] Add scalastyle rule to check...

2018-09-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22581 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22581: [SPARK-25565][BUILD] Add scalastyle rule to check...

2018-09-28 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22581#discussion_r221333480 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -975,7 +975,7 @@ object SQLConf { "checkpoint

[GitHub] spark pull request #22581: [SPARK-25565][BUILD] Add scalastyle rule to check...

2018-09-28 Thread wangyum
Github user wangyum commented on a diff in the pull request: https://github.com/apache/spark/pull/22581#discussion_r221213500 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -975,7 +975,7 @@ object SQLConf { "checkpoint

[GitHub] spark pull request #22581: [SPARK-25565][BUILD] Add scalastyle rule to check...

2018-09-28 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/22581 [SPARK-25565][BUILD] Add scalastyle rule to check add Locale.ROOT to .toLowerCase and .toUpperCase for internal calls ## What changes were proposed in this pull request? This PR adds