[GitHub] spark pull request #22626: [SPARK-25638][SQL] Adding new function - to_csv()

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22626 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22626: [SPARK-25638][SQL] Adding new function - to_csv()

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22626#discussion_r230577431 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala --- @@ -174,3 +176,68 @@ case class SchemaOfCsv(

[GitHub] spark pull request #22626: [SPARK-25638][SQL] Adding new function - to_csv()

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22626#discussion_r230559020 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityGenerator.scala --- @@ -15,18 +15,17 @@ * limitations under the

[GitHub] spark pull request #22626: [SPARK-25638][SQL] Adding new function - to_csv()

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22626#discussion_r230559006 --- Diff: sql/core/src/test/resources/sql-tests/inputs/csv-functions.sql --- @@ -15,3 +15,10 @@ CREATE TEMPORARY VIEW csvTable(csvField, a) AS SELECT *

[GitHub] spark pull request #22626: [SPARK-25638][SQL] Adding new function - to_csv()

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22626#discussion_r230555774 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala --- @@ -174,3 +176,66 @@ case class SchemaOfCsv(

[GitHub] spark pull request #22626: [SPARK-25638][SQL] Adding new function - to_csv()

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22626#discussion_r230544775 --- Diff: sql/core/src/test/resources/sql-tests/inputs/csv-functions.sql --- @@ -15,3 +15,10 @@ CREATE TEMPORARY VIEW csvTable(csvField, a) AS SELECT *

[GitHub] spark pull request #22626: [SPARK-25638][SQL] Adding new function - to_csv()

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22626#discussion_r230544760 --- Diff: sql/core/src/test/resources/sql-tests/inputs/csv-functions.sql --- @@ -15,3 +15,10 @@ CREATE TEMPORARY VIEW csvTable(csvField, a) AS SELECT *

[GitHub] spark pull request #22626: [SPARK-25638][SQL] Adding new function - to_csv()

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22626#discussion_r230544717 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala --- @@ -174,3 +176,66 @@ case class SchemaOfCsv(

[GitHub] spark pull request #22626: [SPARK-25638][SQL] Adding new function - to_csv()

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22626#discussion_r230544667 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala --- @@ -174,3 +176,66 @@ case class SchemaOfCsv(

[GitHub] spark pull request #22626: [SPARK-25638][SQL] Adding new function - to_csv()

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22626#discussion_r230544556 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CsvFunctionsSuite.scala --- @@ -45,7 +45,6 @@ class CsvFunctionsSuite extends QueryTest with

[GitHub] spark pull request #22626: [SPARK-25638][SQL] Adding new function - to_csv()

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22626#discussion_r230544492 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityGenerator.scala --- @@ -15,18 +15,17 @@ * limitations under the

[GitHub] spark pull request #22626: [SPARK-25638][SQL] Adding new function - to_csv()

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22626#discussion_r230028296 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala --- @@ -174,3 +176,66 @@ case class SchemaOfCsv(

[GitHub] spark pull request #22626: [SPARK-25638][SQL] Adding new function - to_csv()

Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22626#discussion_r230027771 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CsvFunctionsSuite.scala --- @@ -45,7 +45,6 @@ class CsvFunctionsSuite extends QueryTest with

[GitHub] spark pull request #22626: [SPARK-25638][SQL] Adding new function - to_csv()

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22626#discussion_r229981376 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala --- @@ -3905,6 +3905,47 @@ object functions {

[GitHub] spark pull request #22626: [SPARK-25638][SQL] Adding new function - to_csv()

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22626#discussion_r229981416 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/CsvFunctionsSuite.scala --- @@ -45,7 +45,6 @@ class CsvFunctionsSuite extends QueryTest with

[GitHub] spark pull request #22626: [SPARK-25638][SQL] Adding new function - to_csv()

Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22626#discussion_r229981271 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala --- @@ -174,3 +176,66 @@ case class SchemaOfCsv(

[GitHub] spark pull request #22626: [SPARK-25638][SQL] Adding new function - to_csv()

GitHub user MaxGekk opened a pull request: https://github.com/apache/spark/pull/22626 [SPARK-25638][SQL] Adding new function - to_csv() ## What changes were proposed in this pull request? New functions takes a struct and converts it to a CSV strings using passed CSV