[GitHub] spark pull request #22685: [SQL][MINOR][Refactor] Refactor on sql/core

2018-10-11 Thread sadhen
Github user sadhen closed the pull request at: https://github.com/apache/spark/pull/22685 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22685: [SQL][MINOR][Refactor] Refactor on sql/core

2018-10-10 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22685#discussion_r224317853 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala --- @@ -96,7 +95,7 @@ case class DataSource(

[GitHub] spark pull request #22685: [SQL][MINOR][Refactor] Refactor on sql/core

2018-10-10 Thread sadhen
Github user sadhen commented on a diff in the pull request: https://github.com/apache/spark/pull/22685#discussion_r224054521 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala --- @@ -147,7 +147,7 @@ private[sql] object

[GitHub] spark pull request #22685: [SQL][MINOR][Refactor] Refactor on sql/core

2018-10-10 Thread sadhen
Github user sadhen commented on a diff in the pull request: https://github.com/apache/spark/pull/22685#discussion_r224054362 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/metric/SQLMetrics.scala --- @@ -95,7 +95,7 @@ object SQLMetrics { def

[GitHub] spark pull request #22685: [SQL][MINOR][Refactor] Refactor on sql/core

2018-10-10 Thread sadhen
Github user sadhen commented on a diff in the pull request: https://github.com/apache/spark/pull/22685#discussion_r224053894 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala --- @@ -567,10 +567,10 @@ class KeyValueGroupedDataset[K, V]

[GitHub] spark pull request #22685: [SQL][MINOR][Refactor] Refactor on sql/core

2018-10-10 Thread sadhen
Github user sadhen commented on a diff in the pull request: https://github.com/apache/spark/pull/22685#discussion_r224054020 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/r/SQLUtils.scala --- @@ -188,7 +188,7 @@ private[sql] object SQLUtils extends Logging {

[GitHub] spark pull request #22685: [SQL][MINOR][Refactor] Refactor on sql/core

2018-10-10 Thread sadhen
Github user sadhen commented on a diff in the pull request: https://github.com/apache/spark/pull/22685#discussion_r224053653 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala --- @@ -123,7 +123,7 @@ object StaticSQLConf { val