Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22698
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22698#discussion_r224659990
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -506,18 +513,18 @@ case class RangeExec(range:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22698#discussion_r224659380
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -506,18 +513,18 @@ case class RangeExec(range:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22698#discussion_r224659093
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -506,18 +513,18 @@ case class RangeExec(range:
Github user wangyum commented on a diff in the pull request:
https://github.com/apache/spark/pull/22698#discussion_r224563916
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/RangeBenchmark.scala
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22698#discussion_r224511158
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -506,18 +513,18 @@ case class RangeExec(range:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22698#discussion_r224503636
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -506,18 +513,18 @@ case class RangeExec(range:
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22698#discussion_r224497604
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -506,18 +513,18 @@ case class RangeExec(range:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22698#discussion_r224492454
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -506,18 +513,18 @@ case class RangeExec(range:
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22698#discussion_r224485031
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala
---
@@ -506,18 +513,18 @@ case class RangeExec(range:
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22698#discussion_r224484333
--- Diff: sql/core/benchmarks/RangeBenchmark-results.txt ---
@@ -0,0 +1,16 @@
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22698#discussion_r224483681
--- Diff: sql/core/benchmarks/RangeBenchmark-results.txt ---
@@ -0,0 +1,16 @@
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/22698
[SPARK-25710][SQL] range should report metrics correctly
## What changes were proposed in this pull request?
Currently `Range` reports metrics in batch granularity. This is acceptable,
13 matches
Mail list logo
