[GitHub] spark pull request #22728: [SPARK-25736][SQL][TEST] add tests to verify the ...

2018-10-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22728 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22728: [SPARK-25736][SQL][TEST] add tests to verify the ...

2018-10-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/22728#discussion_r225299298 --- Diff: sql/core/src/test/resources/sql-tests/inputs/count.sql --- @@ -0,0 +1,21 @@ +-- Test data. +CREATE OR REPLACE TEMPORARY VIEW testData

[GitHub] spark pull request #22728: [SPARK-25736][SQL][TEST] add tests to verify the ...

2018-10-15 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/22728#discussion_r225298840 --- Diff: sql/core/src/test/resources/sql-tests/inputs/count.sql --- @@ -0,0 +1,21 @@ +-- Test data. +CREATE OR REPLACE TEMPORARY VIEW testData

[GitHub] spark pull request #22728: [SPARK-25736][SQL][TEST] add tests to verify the ...

2018-10-15 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/22728 [SPARK-25736][SQL][TEST] add tests to verify the behavior of multi-column count ## What changes were proposed in this pull request? AFAIK multi-column count is not widely supported by