Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22750
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22750#discussion_r226819049
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -168,10 +168,11 @@ case class FileSourceScanExec(
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22750#discussion_r226818662
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -168,10 +168,11 @@ case class FileSourceScanExec(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22750#discussion_r226812447
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarBatchScan.scala
---
@@ -164,12 +162,11 @@ private[sql] trait ColumnarBatchScan
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22750#discussion_r226806646
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ColumnarBatchScan.scala
---
@@ -164,12 +162,11 @@ private[sql] trait ColumnarBatchScan
GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/22750
[SPARK-25747][SQL] remove ColumnarBatchScan.needsUnsafeRowConversion
## What changes were proposed in this pull request?
`needsUnsafeRowConversion` is used in 2 places:
1.
