Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22755
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22755#discussion_r229155463
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -669,22 +669,20 @@ class DataFrameAggregateSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22755#discussion_r229154981
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -459,6 +459,7 @@ private[spark] class Executor(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22755#discussion_r228780582
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala ---
@@ -166,6 +167,17 @@ private[sql] trait SQLTestUtilsBase
Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22755#discussion_r227215773
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/joins/ExistenceJoinSuite.scala
---
@@ -122,19 +122,22 @@ class ExistenceJoinSuite extends
GitHub user heary-cao opened a pull request:
https://github.com/apache/spark/pull/22755
[SPARK-25755][SQL][Test] Supplementation of non-CodeGen unit tested for
BroadcastHashJoinExec
## What changes were proposed in this pull request?
Currently, the BroadcastHashJoinExec
