[GitHub] spark pull request #22785: [SPARK-25791][SQL] Datatype of serializers in Row...

2018-10-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22785 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22785: [SPARK-25791][SQL] Datatype of serializers in Row...

2018-10-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22785#discussion_r227314368 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala --- @@ -187,7 +187,7 @@ object RowEncoder { val

[GitHub] spark pull request #22785: [SPARK-25791][SQL] Datatype of serializers in Row...

2018-10-23 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22785#discussion_r227310290 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/RowEncoderSuite.scala --- @@ -273,6 +273,16 @@ class RowEncoderSuite extends

[GitHub] spark pull request #22785: [SPARK-25791][SQL] Datatype of serializers in Row...

2018-10-22 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22785#discussion_r226979620 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/RowEncoderSuite.scala --- @@ -273,6 +273,16 @@ class RowEncoderSuite extends

[GitHub] spark pull request #22785: [SPARK-25791][SQL] Datatype of serializers in Row...

2018-10-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22785#discussion_r226978705 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala --- @@ -187,7 +187,7 @@ object RowEncoder {

[GitHub] spark pull request #22785: [SPARK-25791][SQL] Datatype of serializers in Row...

2018-10-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22785#discussion_r226978368 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala --- @@ -171,7 +171,7 @@ object RowEncoder {

[GitHub] spark pull request #22785: [SPARK-25791][SQL] Datatype of serializers in Row...

2018-10-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22785#discussion_r226978811 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/RowEncoderSuite.scala --- @@ -273,6 +273,16 @@ class RowEncoderSuite

[GitHub] spark pull request #22785: [SPARK-25791][SQL] Datatype of serializers in Row...

2018-10-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22785#discussion_r226977895 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/RowEncoder.scala --- @@ -171,7 +171,7 @@ object RowEncoder {

[GitHub] spark pull request #22785: [SPARK-25791][SQL] Datatype of serializers in Row...

2018-10-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22785#discussion_r226977568 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/encoders/RowEncoderSuite.scala --- @@ -273,6 +273,16 @@ class RowEncoderSuite

[GitHub] spark pull request #22785: [SPARK-25791][SQL] Datatype of serializers in Row...

2018-10-20 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/22785 [SPARK-25791][SQL] Datatype of serializers in RowEncoder should be accessible ## What changes were proposed in this pull request? The serializers of `RowEncoder` use few `If` Catalyst