[GitHub] spark pull request #22789: [SPARK-25767][SQL] Fix lazily evaluated stream of...

2018-10-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22789 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22789: [SPARK-25767][SQL] Fix lazily evaluated stream of...

2018-10-28 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/22789#discussion_r228760802 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala --- @@ -319,4 +319,15 @@ class WholeStageCodegenSuite

[GitHub] spark pull request #22789: [SPARK-25767][SQL] Fix lazily evaluated stream of...

2018-10-28 Thread peter-toth
Github user peter-toth commented on a diff in the pull request: https://github.com/apache/spark/pull/22789#discussion_r228753985 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -146,7 +146,10 @@ trait CodegenSupport extends

[GitHub] spark pull request #22789: [SPARK-25767][SQL] Fix lazily evaluated stream of...

2018-10-28 Thread peter-toth
Github user peter-toth commented on a diff in the pull request: https://github.com/apache/spark/pull/22789#discussion_r228753682 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala --- @@ -319,4 +319,15 @@ class WholeStageCodegenSuite

[GitHub] spark pull request #22789: [SPARK-25767][SQL] Fix lazily evaluated stream of...

2018-10-28 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/22789#discussion_r228749168 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -146,7 +146,10 @@ trait CodegenSupport extends

[GitHub] spark pull request #22789: [SPARK-25767][SQL] Fix lazily evaluated stream of...

2018-10-28 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/22789#discussion_r228748979 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala --- @@ -319,4 +319,15 @@ class WholeStageCodegenSuite

[GitHub] spark pull request #22789: [SPARK-25767][SQL] Fix lazily evaluated stream of...

2018-10-22 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22789#discussion_r227008114 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala --- @@ -146,7 +146,7 @@ trait CodegenSupport extends