Github user shaneknapp commented on a diff in the pull request:
https://github.com/apache/spark/pull/22854#discussion_r228607477
--- Diff: build/mvn ---
@@ -163,8 +163,14 @@ export MAVEN_OPTS=${MAVEN_OPTS:-"$_COMPILE_JVM_OPTS"}
echo "Using \`mvn\` from path: $MVN_BIN"
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22854#discussion_r228606581
--- Diff: build/mvn ---
@@ -163,8 +163,14 @@ export MAVEN_OPTS=${MAVEN_OPTS:-"$_COMPILE_JVM_OPTS"}
echo "Using \`mvn\` from path: $MVN_BIN"
Github user shaneknapp commented on a diff in the pull request:
https://github.com/apache/spark/pull/22854#discussion_r228591941
--- Diff: build/mvn ---
@@ -163,8 +163,19 @@ export MAVEN_OPTS=${MAVEN_OPTS:-"$_COMPILE_JVM_OPTS"}
echo "Using \`mvn\` from path: $MVN_BIN"
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22854#discussion_r228588061
--- Diff: build/mvn ---
@@ -163,8 +163,19 @@ export MAVEN_OPTS=${MAVEN_OPTS:-"$_COMPILE_JVM_OPTS"}
echo "Using \`mvn\` from path: $MVN_BIN"
Github user shaneknapp commented on a diff in the pull request:
https://github.com/apache/spark/pull/22854#discussion_r228584294
--- Diff: build/mvn ---
@@ -163,8 +163,19 @@ export MAVEN_OPTS=${MAVEN_OPTS:-"$_COMPILE_JVM_OPTS"}
echo "Using \`mvn\` from path: $MVN_BIN"
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22854#discussion_r228583684
--- Diff: build/mvn ---
@@ -163,8 +163,19 @@ export MAVEN_OPTS=${MAVEN_OPTS:-"$_COMPILE_JVM_OPTS"}
echo "Using \`mvn\` from path: $MVN_BIN" 1>&2
GitHub user shaneknapp opened a pull request:
https://github.com/apache/spark/pull/22854
[SPARK-25854] fix mvn to not always exit 1
## What changes were proposed in this pull request?
the final line in the mvn helper script in build/ attempts to shut down the
zinc server.
