Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22987
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/22987#discussion_r232136609
--- Diff: sql/core/src/test/resources/sql-tests/inputs/window.sql ---
@@ -109,3 +109,9 @@ last_value(false, false) OVER w AS
last_value_contain_null
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22987#discussion_r232135028
--- Diff: sql/core/src/test/resources/sql-tests/inputs/window.sql ---
@@ -109,3 +109,9 @@ last_value(false, false) OVER w AS
last_value_contain_null
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22987#discussion_r231992909
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala
---
@@ -31,6 +32,19 @@ class SQLWindowFunctionSuite
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22987#discussion_r231992777
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala
---
@@ -31,6 +32,19 @@ class SQLWindowFunctionSuite
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/22987#discussion_r231962213
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/SQLWindowFunctionSuite.scala
---
@@ -31,6 +32,19 @@ class SQLWindowFunctionSuite
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/22987
[SPARK-25979][SQL] Window function: allow parentheses around window
reference
## What changes were proposed in this pull request?
Very minor parser bug, but possibly problematic for
