[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-14 Thread srowen
Github user srowen closed the pull request at: https://github.com/apache/spark/pull/22993 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-13 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r233222902 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala --- @@ -193,6 +194,36 @@ private[spark] class StorageStatus( /** Helper

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-13 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r233216872 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala --- @@ -193,6 +194,36 @@ private[spark] class StorageStatus( /** Helper

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-13 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r233166698 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala --- @@ -193,6 +194,36 @@ private[spark] class StorageStatus( /** Helper

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-13 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r233124864 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala --- @@ -193,6 +194,36 @@ private[spark] class StorageStatus( /** Helper

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-13 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r233124434 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala --- @@ -193,6 +194,36 @@ private[spark] class StorageStatus( /** Helper

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-13 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r233002403 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala --- @@ -193,6 +194,36 @@ private[spark] class StorageStatus( /** Helper

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-13 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r232980913 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala --- @@ -193,6 +194,36 @@ private[spark] class StorageStatus( /** Helper

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-12 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r232867047 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala --- @@ -193,6 +194,36 @@ private[spark] class StorageStatus( /** Helper

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r232852693 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java --- @@ -67,6 +67,59 @@ unaligned = _unaligned; } + //

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-12 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r232849773 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala --- @@ -193,6 +194,36 @@ private[spark] class StorageStatus( /** Helper

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-12 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r232849634 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala --- @@ -193,6 +194,36 @@ private[spark] class StorageStatus( /** Helper

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-12 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r232848389 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java --- @@ -67,6 +67,60 @@ unaligned = _unaligned; } + //

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r232847703 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala --- @@ -193,6 +194,36 @@ private[spark] class StorageStatus( /** Helper

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r232847435 --- Diff: core/src/main/scala/org/apache/spark/storage/StorageUtils.scala --- @@ -193,6 +194,36 @@ private[spark] class StorageStatus( /** Helper

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-12 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r232846926 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java --- @@ -67,6 +67,60 @@ unaligned = _unaligned; } + //

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-11 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r232500600 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java --- @@ -67,6 +67,59 @@ unaligned = _unaligned; } + //

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r232499645 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java --- @@ -67,6 +67,59 @@ unaligned = _unaligned; }

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-11 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r232492843 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java --- @@ -67,6 +67,59 @@ unaligned = _unaligned; } + //

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-11 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r232488912 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java --- @@ -67,6 +67,59 @@ unaligned = _unaligned; } + //

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-11 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22993#discussion_r232477875 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java --- @@ -67,6 +67,59 @@ unaligned = _unaligned; }

[GitHub] spark pull request #22993: [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cle...

2018-11-09 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/22993 [SPARK-24421][BUILD][CORE] Accessing sun.misc.Cleaner in JDK11 …. Other related changes to get JDK 11 working, to test ## What changes were proposed in this pull request? -