[GitHub] spark pull request #23000: [SPARK-26002][SQL] Fix day of year calculation fo...

2018-11-20 Thread attilapiros
Github user attilapiros commented on a diff in the pull request: https://github.com/apache/spark/pull/23000#discussion_r234992152 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala --- @@ -410,6 +410,30 @@ class DateTimeUtilsSuite

[GitHub] spark pull request #23000: [SPARK-26002][SQL] Fix day of year calculation fo...

2018-11-20 Thread attilapiros
Github user attilapiros commented on a diff in the pull request: https://github.com/apache/spark/pull/23000#discussion_r234986530 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala --- @@ -410,6 +410,30 @@ class DateTimeUtilsSuite

[GitHub] spark pull request #23000: [SPARK-26002][SQL] Fix day of year calculation fo...

2018-11-19 Thread bersprockets
Github user bersprockets commented on a diff in the pull request: https://github.com/apache/spark/pull/23000#discussion_r234819827 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala --- @@ -410,6 +410,30 @@ class DateTimeUtilsSuite

[GitHub] spark pull request #23000: [SPARK-26002][SQL] Fix day of year calculation fo...

2018-11-19 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/23000#discussion_r234807971 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DateTimeUtilsSuite.scala --- @@ -410,6 +410,30 @@ class DateTimeUtilsSuite extends

[GitHub] spark pull request #23000: [SPARK-26002][SQL] Fix day of year calculation fo...

2018-11-10 Thread attilapiros
GitHub user attilapiros opened a pull request: https://github.com/apache/spark/pull/23000 [SPARK-26002][SQL] Fix day of year calculation for Julian calendar days ## What changes were proposed in this pull request? Fixing leap year calculations for date operators