Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23043
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user adoron commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r235685712
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -723,4 +723,18 @@ class DataFrameAggregateSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r235685381
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -723,4 +723,18 @@ class DataFrameAggregateSuite extends
Github user adoron commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r235683861
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -723,4 +723,18 @@ class DataFrameAggregateSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r235596825
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -723,4 +723,18 @@ class DataFrameAggregateSuite extends
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r235244695
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -128,6 +133,11 @@ public static double getDouble(Object object, long
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r235244686
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -120,6 +120,11 @@ public static float getFloat(Object object, long
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r235237427
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java ---
@@ -157,4 +159,15 @@ public void heapMemoryReuse() {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r235237048
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java ---
@@ -157,4 +159,15 @@ public void heapMemoryReuse() {
Github user adoron commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r234942649
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -723,4 +723,32 @@ class DataFrameAggregateSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r234847102
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -723,4 +723,32 @@ class DataFrameAggregateSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r234847137
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -723,4 +723,32 @@ class DataFrameAggregateSuite extends
Github user adoron commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r234676540
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -723,4 +723,32 @@ class DataFrameAggregateSuite extends
Github user adoron commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r234674948
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java ---
@@ -157,4 +159,15 @@ public void heapMemoryReuse() {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r234476361
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala ---
@@ -723,4 +723,32 @@ class DataFrameAggregateSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r234475978
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java ---
@@ -157,4 +159,15 @@ public void heapMemoryReuse() {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r234476055
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java ---
@@ -157,4 +159,15 @@ public void heapMemoryReuse() {
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r234475858
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -120,6 +120,9 @@ public static float getFloat(Object object, long
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r233951725
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -56,17 +56,32 @@ case class
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r233951670
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
---
@@ -56,17 +56,32 @@ case class
GitHub user adoron opened a pull request:
https://github.com/apache/spark/pull/23043
[SPARK-26021][SQL] replace minus zero with zero in UnsafeProjection
GROUP BY treats -0.0 and 0.0 as different values which is unlike hive's
behavior.
In addition current behavior with codegen
21 matches
Mail list logo
