Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/23054#discussion_r234475488
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -17,6 +17,9 @@ displayTitle: Spark SQL Upgrading Guide
- The `ADD JAR` command previously
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23054#discussion_r234475321
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1594,6 +1594,15 @@ object SQLConf {
"WHERE, which
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23054#discussion_r234475156
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -17,6 +17,9 @@ displayTitle: Spark SQL Upgrading Guide
- The `ADD JAR` command
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/23054#discussion_r234408150
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -17,6 +17,8 @@ displayTitle: Spark SQL Upgrading Guide
- The `ADD JAR` command previously
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23054#discussion_r234401319
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -17,6 +17,8 @@ displayTitle: Spark SQL Upgrading Guide
- The `ADD JAR` command
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/23054
[SPARK-26085][SQL] Key attribute of primitive type under typed aggregation
should be named as "key" too
## What changes were proposed in this pull request?
When doing typed aggregation on
