[GitHub] spark pull request #23096: [SPARK-26129][SQL] Instrumentation for per-query ...

2018-11-21 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/23096#discussion_r235505190 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -648,7 +648,11 @@ class SparkSession private( * @since 2.0.0

[GitHub] spark pull request #23096: [SPARK-26129][SQL] Instrumentation for per-query ...

2018-11-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/23096 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #23096: [SPARK-26129][SQL] Instrumentation for per-query ...

2018-11-21 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/23096#discussion_r235309483 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -648,7 +648,11 @@ class SparkSession private( * @since 2.0.0

[GitHub] spark pull request #23096: [SPARK-26129][SQL] Instrumentation for per-query ...

2018-11-20 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/23096#discussion_r235185654 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -648,7 +648,11 @@ class SparkSession private( * @since 2.0.0

[GitHub] spark pull request #23096: [SPARK-26129][SQL] Instrumentation for per-query ...

2018-11-20 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/23096#discussion_r235182105 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala --- @@ -88,15 +101,20 @@ abstract class RuleExecutor[TreeType <:

[GitHub] spark pull request #23096: [SPARK-26129][SQL] Instrumentation for per-query ...

2018-11-20 Thread abehm
Github user abehm commented on a diff in the pull request: https://github.com/apache/spark/pull/23096#discussion_r235180423 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala --- @@ -88,15 +101,20 @@ abstract class RuleExecutor[TreeType

[GitHub] spark pull request #23096: [SPARK-26129][SQL] Instrumentation for per-query ...

2018-11-20 Thread abehm
Github user abehm commented on a diff in the pull request: https://github.com/apache/spark/pull/23096#discussion_r235166000 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala --- @@ -88,15 +92,18 @@ abstract class RuleExecutor[TreeType <:

[GitHub] spark pull request #23096: [SPARK-26129][SQL] Instrumentation for per-query ...

2018-11-20 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/23096#discussion_r235162047 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala --- @@ -88,15 +92,18 @@ abstract class RuleExecutor[TreeType <:

[GitHub] spark pull request #23096: [SPARK-26129][SQL] Instrumentation for per-query ...

2018-11-20 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/23096#discussion_r235161825 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -696,7 +701,7 @@ class Analyzer(

[GitHub] spark pull request #23096: [SPARK-26129][SQL] Instrumentation for per-query ...

2018-11-20 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/23096#discussion_r235161336 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/QueryPlanningTracker.scala --- @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #23096: [SPARK-26129][SQL] Instrumentation for per-query ...

2018-11-20 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/23096#discussion_r235159238 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -648,7 +648,11 @@ class SparkSession private( * @since 2.0.0

[GitHub] spark pull request #23096: [SPARK-26129][SQL] Instrumentation for per-query ...

2018-11-20 Thread abehm
Github user abehm commented on a diff in the pull request: https://github.com/apache/spark/pull/23096#discussion_r235137901 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -211,7 +216,7 @@ class Analyzer( case

[GitHub] spark pull request #23096: [SPARK-26129][SQL] Instrumentation for per-query ...

2018-11-20 Thread abehm
Github user abehm commented on a diff in the pull request: https://github.com/apache/spark/pull/23096#discussion_r235141963 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -102,29 +102,34 @@ class Analyzer( this(catalog,

[GitHub] spark pull request #23096: [SPARK-26129][SQL] Instrumentation for per-query ...

2018-11-20 Thread abehm
Github user abehm commented on a diff in the pull request: https://github.com/apache/spark/pull/23096#discussion_r235150178 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/QueryPlanningTracker.scala --- @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #23096: [SPARK-26129][SQL] Instrumentation for per-query ...

2018-11-20 Thread abehm
Github user abehm commented on a diff in the pull request: https://github.com/apache/spark/pull/23096#discussion_r235146495 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisTest.scala --- @@ -54,7 +54,7 @@ trait AnalysisTest extends PlanTest {

[GitHub] spark pull request #23096: [SPARK-26129][SQL] Instrumentation for per-query ...

2018-11-20 Thread abehm
Github user abehm commented on a diff in the pull request: https://github.com/apache/spark/pull/23096#discussion_r235144120 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -696,7 +701,7 @@ class Analyzer(

[GitHub] spark pull request #23096: [SPARK-26129][SQL] Instrumentation for per-query ...

2018-11-20 Thread abehm
Github user abehm commented on a diff in the pull request: https://github.com/apache/spark/pull/23096#discussion_r235151635 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleExecutor.scala --- @@ -88,15 +92,18 @@ abstract class RuleExecutor[TreeType <:

[GitHub] spark pull request #23096: [SPARK-26129][SQL] Instrumentation for per-query ...

2018-11-20 Thread abehm
Github user abehm commented on a diff in the pull request: https://github.com/apache/spark/pull/23096#discussion_r235135213 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/QueryPlanningTracker.scala --- @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request #23096: [SPARK-26129][SQL] Instrumentation for per-query ...

2018-11-20 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/23096#discussion_r235112175 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala --- @@ -648,7 +648,11 @@ class SparkSession private( * @since 2.0.0