[GitHub] spark pull request #23102: [SPARK-26137][CORE] Use Java system property "fil...

2018-11-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/23102 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #23102: [SPARK-26137][CORE] Use Java system property "fil...

2018-11-27 Thread markpavey
Github user markpavey commented on a diff in the pull request: https://github.com/apache/spark/pull/23102#discussion_r236705942 --- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala --- @@ -19,6 +19,7 @@ package org.apache.spark.deploy import

[GitHub] spark pull request #23102: [SPARK-26137][CORE] Use Java system property "fil...

2018-11-27 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/23102#discussion_r236703765 --- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala --- @@ -19,6 +19,7 @@ package org.apache.spark.deploy import

[GitHub] spark pull request #23102: [SPARK-26137][CORE] Use Java system property "fil...

2018-11-27 Thread markpavey
Github user markpavey commented on a diff in the pull request: https://github.com/apache/spark/pull/23102#discussion_r236585831 --- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala --- @@ -61,11 +61,13 @@ private[deploy] object DependencyUtils extends

[GitHub] spark pull request #23102: [SPARK-26137][CORE] Use Java system property "fil...

2018-11-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/23102#discussion_r236347084 --- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala --- @@ -61,11 +61,13 @@ private[deploy] object DependencyUtils extends Logging {

[GitHub] spark pull request #23102: [SPARK-26137][CORE] Use Java system property "fil...

2018-11-26 Thread markpavey
Github user markpavey commented on a diff in the pull request: https://github.com/apache/spark/pull/23102#discussion_r236343933 --- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala --- @@ -19,11 +19,11 @@ package org.apache.spark.deploy import

[GitHub] spark pull request #23102: [SPARK-26137][CORE] Use Java system property "fil...

2018-11-26 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/23102#discussion_r236343465 --- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala --- @@ -61,11 +61,13 @@ private[deploy] object DependencyUtils extends Logging {

[GitHub] spark pull request #23102: [SPARK-26137][CORE] Use Java system property "fil...

2018-11-26 Thread markpavey
Github user markpavey commented on a diff in the pull request: https://github.com/apache/spark/pull/23102#discussion_r236343483 --- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala --- @@ -61,11 +61,13 @@ private[deploy] object DependencyUtils extends

[GitHub] spark pull request #23102: [SPARK-26137][CORE] Use Java system property "fil...

2018-11-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/23102#discussion_r236341207 --- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala --- @@ -19,11 +19,11 @@ package org.apache.spark.deploy import

[GitHub] spark pull request #23102: [SPARK-26137][CORE] Use Java system property "fil...

2018-11-26 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/23102#discussion_r236341337 --- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala --- @@ -61,11 +61,13 @@ private[deploy] object DependencyUtils extends

[GitHub] spark pull request #23102: [SPARK-26137][CORE] Use Java system property "fil...

2018-11-26 Thread markpavey
Github user markpavey commented on a diff in the pull request: https://github.com/apache/spark/pull/23102#discussion_r236340228 --- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala --- @@ -65,7 +65,7 @@ private[deploy] object DependencyUtils extends Logging

[GitHub] spark pull request #23102: [SPARK-26137][CORE] Use Java system property "fil...

2018-11-23 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/23102#discussion_r235975268 --- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala --- @@ -61,11 +62,12 @@ private[deploy] object DependencyUtils extends Logging {

[GitHub] spark pull request #23102: [SPARK-26137][CORE] Use Java system property "fil...

2018-11-22 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/23102#discussion_r235821628 --- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala --- @@ -61,11 +62,12 @@ private[deploy] object DependencyUtils extends Logging {

[GitHub] spark pull request #23102: [SPARK-26137][CORE] Use Java system property "fil...

2018-11-21 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/23102#discussion_r235570156 --- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala --- @@ -65,7 +65,7 @@ private[deploy] object DependencyUtils extends

[GitHub] spark pull request #23102: [SPARK-26137][CORE] Use Java system property "fil...

2018-11-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/23102#discussion_r235546231 --- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala --- @@ -65,7 +65,7 @@ private[deploy] object DependencyUtils extends Logging {

[GitHub] spark pull request #23102: [SPARK-26137][CORE] Use Java system property "fil...

2018-11-21 Thread markpavey
GitHub user markpavey opened a pull request: https://github.com/apache/spark/pull/23102 [SPARK-26137][CORE] Use Java system property "file.separator" inste… … of hard coded "/" in DependencyUtils ## What changes were proposed in this pull request? (Please fill