[GitHub] spark pull request #23105: [SPARK-26140] Enable custom metrics implementatio...

2018-11-24 Thread xuanyuanking
Github user xuanyuanking commented on a diff in the pull request: https://github.com/apache/spark/pull/23105#discussion_r236036258 --- Diff: core/src/main/scala/org/apache/spark/shuffle/metrics.scala --- @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request #23105: [SPARK-26140] Enable custom metrics implementatio...

2018-11-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/23105 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #23105: [SPARK-26140] Enable custom metrics implementatio...

2018-11-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/23105#discussion_r236020103 --- Diff: core/src/main/scala/org/apache/spark/shuffle/metrics.scala --- @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #23105: [SPARK-26140] Enable custom metrics implementatio...

2018-11-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/23105#discussion_r235950427 --- Diff: core/src/main/scala/org/apache/spark/shuffle/ShuffleManager.scala --- @@ -48,7 +48,8 @@ private[spark] trait ShuffleManager { handle:

[GitHub] spark pull request #23105: [SPARK-26140] Enable custom metrics implementatio...

2018-11-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/23105#discussion_r235834225 --- Diff: core/src/main/scala/org/apache/spark/shuffle/ShuffleManager.scala --- @@ -48,7 +48,8 @@ private[spark] trait ShuffleManager {

[GitHub] spark pull request #23105: [SPARK-26140] Enable custom metrics implementatio...

2018-11-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/23105#discussion_r235834136 --- Diff: core/src/main/scala/org/apache/spark/shuffle/metrics.scala --- @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request #23105: [SPARK-26140] Enable custom metrics implementatio...

2018-11-22 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/23105#discussion_r235834088 --- Diff: core/src/main/scala/org/apache/spark/shuffle/ShuffleMetricsReporter.scala --- @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software