GitHub user xuanyuanking opened a pull request:

    https://github.com/apache/spark/pull/23128

    [SPARK-26139][SQL] Support passing shuffle metrics to exchange operator

    ## What changes were proposed in this pull request?
    
    Implement `SQLShuffleMetricsReporter` on the sql side as the customized 
ShuffleMetricsReporter, which extended the `TempShuffleReadMetrics` and update 
SQLMetrics, in this way shuffle metrics can be reported in the SQL UI.
    
    ## How was this patch tested?
    
    Add UT in SQLMetricsSuite.
    Manual test locally, before:
    
![image](https://user-images.githubusercontent.com/4833765/48960517-30f97880-efa8-11e8-982c-92d05938fd1d.png)
    after:
    
![image](https://user-images.githubusercontent.com/4833765/48960587-b54bfb80-efa8-11e8-8e95-7a3c8c74cc5c.png)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuanyuanking/spark SPARK-26142

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/23128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23128
    
----
commit fba590f040c8fd7ce75df3f733f246db18e79ee6
Author: Reynold Xin <rxin@...>
Date:   2018-11-21T14:56:23Z

    [SPARK-26140] Pull TempShuffleReadMetrics creation out of shuffle reader

commit 35b48b21028110742aed7f7f5b5d62109c2f0adf
Author: Reynold Xin <rxin@...>
Date:   2018-11-21T15:02:04Z

    less movement of code

commit 1b556ecf869685af8f34d448ac3f08102a758124
Author: liyuanjian <liyuanjian@...>
Date:   2018-11-23T21:02:25Z

    [SPARK-26142] Implement shuffle read metric in SQL

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to