Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/23131#discussion_r236803943
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2732,6 +2732,20 @@ setMethod("union",
dataFrame(unioned)
})
+#' Return a
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/23131#discussion_r236763355
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2732,6 +2732,20 @@ setMethod("union",
dataFrame(unioned)
})
+#' Return a
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/23131#discussion_r236760822
--- Diff: R/pkg/R/DataFrame.R ---
@@ -2732,6 +2732,20 @@ setMethod("union",
dataFrame(unioned)
})
+#' Return a
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/23131
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23131#discussion_r236057261
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -341,8 +341,6 @@ displayTitle: Spark SQL Upgrading Guide
APIs. Instead, `DataFrame` remains the
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/23131#discussion_r236057105
--- Diff: docs/sql-migration-guide-upgrade.md ---
@@ -341,8 +341,6 @@ displayTitle: Spark SQL Upgrading Guide
APIs. Instead, `DataFrame`
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/23131#discussion_r236054278
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1852,6 +1852,19 @@ class Dataset[T] private[sql](
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23131#discussion_r236052557
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -1852,6 +1852,19 @@ class Dataset[T] private[sql](
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/23131
[SPARK-25908][SQL][FOLLOW-UP] Add back unionAll
## What changes were proposed in this pull request?
This PR is to add back `unionAll`, which is widely used. The name is also
consistent with
