[GitHub] spark pull request #23143: [SPARK-24762][SQL][Followup] Enable Option of Pro...

2018-11-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/23143 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #23143: [SPARK-24762][SQL][Followup] Enable Option of Pro...

2018-11-26 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/23143#discussion_r236295606 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala --- @@ -251,19 +251,15 @@ case class

[GitHub] spark pull request #23143: [SPARK-24762][SQL][Followup] Enable Option of Pro...

2018-11-26 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/23143#discussion_r236267692 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala --- @@ -251,19 +251,15 @@ case class

[GitHub] spark pull request #23143: [SPARK-24762][SQL][Followup] Enable Option of Pro...

2018-11-26 Thread viirya
GitHub user viirya opened a pull request: https://github.com/apache/spark/pull/23143 [SPARK-24762][SQL][Followup] Enable Option of Product encoders ## What changes were proposed in this pull request? This is follow-up of #21732. This patch inlines `isOptionType` method.