[GitHub] spark pull request #23194: [MINOR][SQL] Combine the same codes in test cases

Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/23194 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #23194: [MINOR][SQL] Combine the same codes in test cases

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/23194#discussion_r238526892 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -377,41 +377,41 @@ abstract class DDLSuite extends QueryTest

[GitHub] spark pull request #23194: [MINOR][SQL] Combine the same codes in test cases

Github user CarolinePeng commented on a diff in the pull request: https://github.com/apache/spark/pull/23194#discussion_r238523807 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -377,41 +377,42 @@ abstract class DDLSuite extends

[GitHub] spark pull request #23194: [MINOR][SQL] Combine the same codes in test cases

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/23194#discussion_r238256775 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -439,31 +440,22 @@ abstract class DDLSuite extends QueryTest

[GitHub] spark pull request #23194: [MINOR][SQL] Combine the same codes in test cases

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/23194#discussion_r238256611 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -377,41 +377,42 @@ abstract class DDLSuite extends QueryTest

[GitHub] spark pull request #23194: [MINOR][SQL] Combine the same codes in test cases

Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/23194#discussion_r238256563 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -377,41 +377,42 @@ abstract class DDLSuite extends QueryTest

[GitHub] spark pull request #23194: [MINOR][SQL] Combine the same codes in test cases

Github user CarolinePeng commented on a diff in the pull request: https://github.com/apache/spark/pull/23194#discussion_r238063442 --- Diff: core/src/main/scala/org/apache/spark/memory/ExecutionMemoryPool.scala --- @@ -37,7 +37,7 @@ import org.apache.spark.internal.Logging *

[GitHub] spark pull request #23194: [MINOR][SQL] Combine the same codes in test cases

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/23194#discussion_r238062387 --- Diff: core/src/main/scala/org/apache/spark/memory/ExecutionMemoryPool.scala --- @@ -37,7 +37,7 @@ import org.apache.spark.internal.Logging * tasks

[GitHub] spark pull request #23194: [MINOR][SQL] Combine the same codes in test cases

Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/23194#discussion_r238062396 --- Diff: core/src/main/scala/org/apache/spark/memory/StorageMemoryPool.scala --- @@ -28,7 +28,7 @@ import org.apache.spark.storage.memory.MemoryStore

[GitHub] spark pull request #23194: [MINOR][SQL] Combine the same codes in test cases

GitHub user CarolinePeng opened a pull request: https://github.com/apache/spark/pull/23194 [MINOR][SQL] Combine the same codes in test cases ## What changes were proposed in this pull request? In the DDLSuit, there are four test cases have the same codes , writing a