Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1374584553 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala: ## @@ -884,19 +884,39 @@ object ShowTables { } /** - * The logical

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1374574757 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala: ## @@ -4055,19 +4055,28 @@ class AstBuilder extends DataTypeAstBuilder with

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1374453999 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolvePartitionSpec.scala: ## @@ -50,6 +50,16 @@ object ResolvePartitionSpec extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

beliefer commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1372811304 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolvePartitionSpec.scala: ## @@ -50,6 +50,16 @@ object ResolvePartitionSpec extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

beliefer commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1372811304 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolvePartitionSpec.scala: ## @@ -50,6 +50,16 @@ object ResolvePartitionSpec extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1372606005 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolvePartitionSpec.scala: ## @@ -50,6 +50,16 @@ object ResolvePartitionSpec extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1372583615 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolvePartitionSpec.scala: ## @@ -50,6 +50,16 @@ object ResolvePartitionSpec extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1372537061 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowTablesSuiteBase.scala: ## @@ -126,4 +127,512 @@ trait ShowTablesSuiteBase extends QueryTest

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1372536605 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolvePartitionSpec.scala: ## @@ -50,6 +50,16 @@ object ResolvePartitionSpec extends

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

MaxGekk commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1372183519 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowTablesSuiteBase.scala: ## @@ -126,4 +127,512 @@ trait ShowTablesSuiteBase extends QueryTest with

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1367896387 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/ShowTablesSuite.scala: ## @@ -18,8 +18,9 @@ package org.apache.spark.sql.execution.command.v2

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1367896333 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala: ## @@ -53,4 +82,95 @@ case class ShowTablesExec( case _ =>

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1367896135 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala: ## @@ -53,4 +82,95 @@ case class ShowTablesExec( case _ =>

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

panbingkun commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1367896086 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala: ## @@ -33,15 +41,36 @@ case class ShowTablesExec( output:

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

panbingkun commented on PR #37588: URL: https://github.com/apache/spark/pull/37588#issuecomment-1771049872 Okay, I'll update later, Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1365553647 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/v2/ShowTablesSuite.scala: ## @@ -18,8 +18,9 @@ package org.apache.spark.sql.execution.command.v2

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1365547706 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala: ## @@ -33,15 +41,36 @@ case class ShowTablesExec( output:

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1365551061 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala: ## @@ -53,4 +82,95 @@ case class ShowTablesExec( case _ =>

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1365548828 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala: ## @@ -53,4 +82,95 @@ case class ShowTablesExec( case _ =>

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

cloud-fan commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1365540128 ## sql/catalyst/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Implicits.scala: ## @@ -65,6 +70,11 @@ object DataSourceV2Implicits {

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

panbingkun commented on PR #37588: URL: https://github.com/apache/spark/pull/37588#issuecomment-1769744166 In addition to the issue of replacing strings with variable names in the review, I also found several other similar points in `ShowTablesSuite` that have been corrected. -- This is

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

github-actions[bot] closed pull request #37588: [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 URL: https://github.com/apache/spark/pull/37588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

MaxGekk commented on code in PR #37588: URL: https://github.com/apache/spark/pull/37588#discussion_r1364047573 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala: ## @@ -404,6 +404,13 @@ class DataSourceV2Strategy(session:

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

panbingkun commented on PR #37588: URL: https://github.com/apache/spark/pull/37588#issuecomment-1767530944 > @panbingkun Could you rebase it on the recent master, please. Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

panbingkun opened a new pull request, #37588: URL: https://github.com/apache/spark/pull/37588 ### What changes were proposed in this pull request? The pr aim to implement v2 SHOW TABLE EXTENDED as `ShowTableExec` ### Why are the changes needed? To have feature parity with the

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

panbingkun commented on PR #37588: URL: https://github.com/apache/spark/pull/37588#issuecomment-1765498209 > @panbingkun Could you rebase it on the recent master, please. Okay, I will do it today. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

github-actions[bot] closed pull request #37588: [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 URL: https://github.com/apache/spark/pull/37588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

MaxGekk commented on PR #37588: URL: https://github.com/apache/spark/pull/37588#issuecomment-1764531574 @panbingkun Could you rebase it on the recent master, please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

Fokko commented on PR #37588: URL: https://github.com/apache/spark/pull/37588#issuecomment-1763905260 @panbingkun @MaxGekk Any plans to get this in at some point? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [SPARK-33393][SQL] Support SHOW TABLE EXTENDED in v2 [spark]

github-actions[bot] commented on PR #37588: URL: https://github.com/apache/spark/pull/37588#issuecomment-1763551022 We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.

<    1   2