Re: [PR] [SPARK-44496][SQL][FOLLOW-UP] CalendarIntervalType is also orderable [spark]

2024-01-13 Thread via GitHub
amaliujia closed pull request #43805: [SPARK-44496][SQL][FOLLOW-UP] CalendarIntervalType is also orderable URL: https://github.com/apache/spark/pull/43805 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [SPARK-44496][SQL][FOLLOW-UP] CalendarIntervalType is also orderable [spark]

2023-11-15 Thread via GitHub
cloud-fan commented on PR #43805: URL: https://github.com/apache/spark/pull/43805#issuecomment-1812104254 So we just need to update the doc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SPARK-44496][SQL][FOLLOW-UP] CalendarIntervalType is also orderable [spark]

2023-11-15 Thread via GitHub
cloud-fan commented on PR #43805: URL: https://github.com/apache/spark/pull/43805#issuecomment-1811991530 it's not really comparable as we can't compare `30 days` and `1 month`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [SPARK-44496][SQL][FOLLOW-UP] CalendarIntervalType is also orderable [spark]

2023-11-14 Thread via GitHub
yaooqinn commented on PR #43805: URL: https://github.com/apache/spark/pull/43805#issuecomment-1811732522 FYI, add orderable support. https://issues.apache.org/jira/browse/SPARK-29679 https://issues.apache.org/jira/browse/SPARK-29385 drop orderable support.

Re: [PR] [SPARK-44496][SQL][FOLLOW-UP] CalendarIntervalType is also orderable [spark]

2023-11-14 Thread via GitHub
HyukjinKwon commented on code in PR #43805: URL: https://github.com/apache/spark/pull/43805#discussion_r1393545050 ## sql/api/src/main/scala/org/apache/spark/sql/catalyst/expressions/OrderUtils.scala: ## @@ -16,15 +16,16 @@ */ package

Re: [PR] [SPARK-44496][SQL][FOLLOW-UP] CalendarIntervalType is also orderable [spark]

2023-11-14 Thread via GitHub
amaliujia commented on PR #43805: URL: https://github.com/apache/spark/pull/43805#issuecomment-1811135851 @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [SPARK-44496][SQL][FOLLOW-UP] CalendarIntervalType is also orderable [spark]

2023-11-14 Thread via GitHub
amaliujia opened a new pull request, #43805: URL: https://github.com/apache/spark/pull/43805 ### What changes were proposed in this pull request? CalendarIntervalType is also orderable