cloud-fan closed pull request #43781: [SPARK-45905][SQL] Least common type
between decimal types should retain integral digits first
URL: https://github.com/apache/spark/pull/43781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
cloud-fan commented on PR #43781:
URL: https://github.com/apache/spark/pull/43781#issuecomment-1812465509
The failure is unrelated
```
Extension error:
Could not import extension sphinx_copybutton (exception: No module named
'sphinx_copybutton')
make: *** [Makefile:35: html]
dongjoon-hyun commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1393707711
##
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##
@@ -4541,6 +4541,15 @@ object SQLConf {
.booleanConf
cloud-fan commented on PR #43781:
URL: https://github.com/apache/spark/pull/43781#issuecomment-1811881698
> Is there reproducer that can be added as unit test to show the issue in
e2e example?
I think the updated tests show the problem.
--
This is an automated message from the
cloud-fan commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1393704857
##
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##
@@ -4541,6 +4541,15 @@ object SQLConf {
.booleanConf
cloud-fan commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1393704651
##
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##
@@ -4541,6 +4541,15 @@ object SQLConf {
.booleanConf
dongjoon-hyun commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1393703751
##
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##
@@ -4541,6 +4541,15 @@ object SQLConf {
.booleanConf
cloud-fan commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1393576370
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala:
##
@@ -64,7 +65,11 @@ object DecimalPrecision extends TypeCoercionRule
viirya commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1393385818
##
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##
@@ -4541,6 +4541,15 @@ object SQLConf {
.booleanConf
viirya commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1393383832
##
docs/sql-ref-ansi-compliance.md:
##
@@ -240,6 +240,25 @@ The least common type resolution is used to:
- Derive the result type for expressions such as the case
viirya commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1393380697
##
docs/sql-ref-ansi-compliance.md:
##
@@ -240,6 +240,25 @@ The least common type resolution is used to:
- Derive the result type for expressions such as the case
viirya commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1393380697
##
docs/sql-ref-ansi-compliance.md:
##
@@ -240,6 +240,25 @@ The least common type resolution is used to:
- Derive the result type for expressions such as the case
viirya commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1393379712
##
docs/sql-ref-ansi-compliance.md:
##
@@ -240,6 +240,25 @@ The least common type resolution is used to:
- Derive the result type for expressions such as the case
gengliangwang commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1393339460
##
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##
@@ -4541,6 +4541,15 @@ object SQLConf {
.booleanConf
gengliangwang commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1393331222
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala:
##
@@ -64,7 +65,11 @@ object DecimalPrecision extends
cloud-fan commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1392065605
##
docs/sql-ref-ansi-compliance.md:
##
@@ -240,6 +240,25 @@ The least common type resolution is used to:
- Derive the result type for expressions such as the case
beliefer commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1392060678
##
docs/sql-ref-ansi-compliance.md:
##
@@ -240,6 +240,25 @@ The least common type resolution is used to:
- Derive the result type for expressions such as the case
cloud-fan commented on PR #43781:
URL: https://github.com/apache/spark/pull/43781#issuecomment-1809470848
cc @gengliangwang @viirya @wangyum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cloud-fan commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1391930958
##
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##
@@ -5425,7 +5434,7 @@ class SQLConf extends Serializable with Logging with
SqlApiConf
cloud-fan commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1391930638
##
docs/sql-ref-ansi-compliance.md:
##
@@ -240,6 +240,25 @@ The least common type resolution is used to:
- Derive the result type for expressions such as the case
beliefer commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1391880151
##
docs/sql-ref-ansi-compliance.md:
##
@@ -240,6 +240,25 @@ The least common type resolution is used to:
- Derive the result type for expressions such as the case
ryan-johnson-databricks commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1391756323
##
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##
@@ -5425,7 +5434,7 @@ class SQLConf extends Serializable with Logging
ryan-johnson-databricks commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1391756323
##
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##
@@ -5425,7 +5434,7 @@ class SQLConf extends Serializable with Logging
cloud-fan commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1390832585
##
docs/sql-ref-ansi-compliance.md:
##
@@ -240,6 +240,25 @@ The least common type resolution is used to:
- Derive the result type for expressions such as the case
cloud-fan commented on code in PR #43781:
URL: https://github.com/apache/spark/pull/43781#discussion_r1390832381
##
docs/sql-ref-ansi-compliance.md:
##
@@ -240,6 +240,25 @@ The least common type resolution is used to:
- Derive the result type for expressions such as the case
cloud-fan opened a new pull request, #43781:
URL: https://github.com/apache/spark/pull/43781
### What changes were proposed in this pull request?
This is kind of a followup of https://github.com/apache/spark/pull/20023 .
It's simply wrong to cut the decimal precision to
26 matches
Mail list logo
