Re: [PR] [SPARK-45915][SQL] Treat decimal(x, 0) the same as IntegralType in `PromoteStrings` [spark]

2023-11-15 Thread via GitHub
dongjoon-hyun commented on PR #43812: URL: https://github.com/apache/spark/pull/43812#issuecomment-1812231907 Merged to master for Apache Spark 4.0.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [SPARK-45915][SQL] Treat decimal(x, 0) the same as IntegralType in `PromoteStrings` [spark]

2023-11-15 Thread via GitHub
dongjoon-hyun closed pull request #43812: [SPARK-45915][SQL] Treat decimal(x, 0) the same as IntegralType in `PromoteStrings` URL: https://github.com/apache/spark/pull/43812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [SPARK-45915][SQL] Treat decimal(x, 0) the same as IntegralType in `PromoteStrings` [spark]

2023-11-15 Thread via GitHub
wangyum commented on code in PR #43812: URL: https://github.com/apache/spark/pull/43812#discussion_r1393881574 ## sql/core/src/test/resources/sql-tests/analyzer-results/typeCoercion/native/binaryComparison.sql.out: ## @@ -1330,7 +1330,7 @@ Project [NOT (cast(cast(null as

Re: [PR] [SPARK-45915][SQL] Treat decimal(x, 0) the same as IntegralType in `PromoteStrings` [spark]

2023-11-15 Thread via GitHub
dongjoon-hyun commented on code in PR #43812: URL: https://github.com/apache/spark/pull/43812#discussion_r1393823245 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala: ## @@ -934,8 +934,8 @@ object TypeCoercion extends TypeCoercionBase {

Re: [PR] [SPARK-45915][SQL] Treat decimal(x, 0) the same as IntegralType in `PromoteStrings` [spark]

2023-11-15 Thread via GitHub
dongjoon-hyun commented on code in PR #43812: URL: https://github.com/apache/spark/pull/43812#discussion_r1393820692 ## sql/core/src/test/resources/sql-tests/analyzer-results/typeCoercion/native/binaryComparison.sql.out: ## @@ -1330,7 +1330,7 @@ Project [NOT (cast(cast(null as

[PR] [SPARK-45915][SQL] Treat decimal(x, 0) the same as IntegralType in `PromoteStrings` [spark]

2023-11-14 Thread via GitHub
wangyum opened a new pull request, #43812: URL: https://github.com/apache/spark/pull/43812 ### What changes were proposed in this pull request? The common type of decimal(x, 0) and string is double. But the common type of int/bigint and string are int/bigint. This PR updates