Re: [PR] [SPARK-45925][SQL] Making SubqueryBroadcastExec equivalent to SubqueryAdaptiveBroadcastExec [spark]

2023-11-15 Thread via GitHub
ahshahid commented on PR #43807: URL: https://github.com/apache/spark/pull/43807#issuecomment-1813289805 @beliefer I think you may be right. In my another PR for broadcast-var-pushdown, I am seeing unmodified SubqueryAdaptiveBroadcastExec in the stage cache 's keys. May be it is an issue

Re: [PR] [SPARK-45925][SQL] Making SubqueryBroadcastExec equivalent to SubqueryAdaptiveBroadcastExec [spark]

2023-11-15 Thread via GitHub
ahshahid closed pull request #43807: [SPARK-45925][SQL] Making SubqueryBroadcastExec equivalent to SubqueryAdaptiveBroadcastExec URL: https://github.com/apache/spark/pull/43807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [SPARK-45925][SQL] Making SubqueryBroadcastExec equivalent to SubqueryAdaptiveBroadcastExec [spark]

2023-11-15 Thread via GitHub
ahshahid commented on PR #43807: URL: https://github.com/apache/spark/pull/43807#issuecomment-1811975176 I think if I get clean run on PR [SPARK-45924](https://github.com/apache/spark/pull/43806), then this PR can be closed without merging -- This is an automated message from the Apache

Re: [PR] [SPARK-45925][SQL] Making SubqueryBroadcastExec equivalent to SubqueryAdaptiveBroadcastExec [spark]

2023-11-14 Thread via GitHub
ahshahid commented on PR #43807: URL: https://github.com/apache/spark/pull/43807#issuecomment-1811817204 The other option is that we make the canonicalized form of both SubqueryAdaptiveBroadcastExec and SubqueryBroadcastExec to be of type SubqueryBroadcastExec. that way equals and hashCode

Re: [PR] [SPARK-45925][SQL] Making SubqueryBroadcastExec equivalent to SubqueryAdaptiveBroadcastExec [spark]

2023-11-14 Thread via GitHub
HyukjinKwon commented on PR #43807: URL: https://github.com/apache/spark/pull/43807#issuecomment-1811686321 cc @ulysses-you and @peter-toth FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to