Re: [PR] [SPARK-46510][CORE] Spark shell log filter should be applied to all AbstractAppender [spark]

2024-03-07 Thread via GitHub
AngersZh closed pull request #44496: [SPARK-46510][CORE] Spark shell log filter should be applied to all AbstractAppender URL: https://github.com/apache/spark/pull/44496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [SPARK-46510][CORE] Spark shell log filter should be applied to all AbstractAppender [spark]

2023-12-26 Thread via GitHub
AngersZh commented on code in PR #44496: URL: https://github.com/apache/spark/pull/44496#discussion_r1436378705 ## common/utils/src/main/scala/org/apache/spark/internal/Logging.scala: ## @@ -169,8 +169,8 @@ trait Logging { }

Re: [PR] [SPARK-46510][CORE] Spark shell log filter should be applied to all AbstractAppender [spark]

2023-12-26 Thread via GitHub
beliefer commented on code in PR #44496: URL: https://github.com/apache/spark/pull/44496#discussion_r1436363784 ## common/utils/src/main/scala/org/apache/spark/internal/Logging.scala: ## @@ -169,8 +169,8 @@ trait Logging { }

Re: [PR] [SPARK-46510][CORE] Spark shell log filter should be applied to all AbstractAppender [spark]

2023-12-26 Thread via GitHub
yaooqinn commented on code in PR #44496: URL: https://github.com/apache/spark/pull/44496#discussion_r1436345878 ## common/utils/src/main/scala/org/apache/spark/internal/Logging.scala: ## @@ -169,8 +169,8 @@ trait Logging { }

Re: [PR] [SPARK-46510][CORE] Spark shell log filter should be applied to all AbstractAppender [spark]

2023-12-26 Thread via GitHub
viirya commented on code in PR #44496: URL: https://github.com/apache/spark/pull/44496#discussion_r1436335619 ## common/utils/src/main/scala/org/apache/spark/internal/Logging.scala: ## @@ -169,8 +169,8 @@ trait Logging { } Logging.sparkShellThresholdLevel

Re: [PR] [SPARK-46510][CORE] Spark shell log filter should be applied to all AbstractAppender [spark]

2023-12-26 Thread via GitHub
LuciferYang commented on PR #44496: URL: https://github.com/apache/spark/pull/44496#issuecomment-1869346457 Is this an improvement rather than a bug fix? Does the `Affects Version` not include 3.5.0? Can you provide some screenshots to show the differences before and after? For example,

[PR] [SPARK-46510][CORE] Spark shell log filter should be applied to all AbstractAppender [spark]

2023-12-25 Thread via GitHub
AngersZh opened a new pull request, #44496: URL: https://github.com/apache/spark/pull/44496 ### What changes were proposed in this pull request? Current code `SparkShellLoggingFilter` only applied to `ConsoleAppender`, if we define `AsyncAppender` and ref to console appender it won't