Re: [PR] [SPARK-46654][SQL][Python] Make `to_csv` explicitly indicate that it does not support complex types of data [spark]

2024-03-10 Thread via GitHub
panbingkun commented on code in PR #44665: URL: https://github.com/apache/spark/pull/44665#discussion_r1519100897 ## python/pyspark/sql/functions/builtin.py: ## @@ -15534,19 +15532,7 @@ def to_csv(col: "ColumnOrName", options: Optional[Dict[str, str]] = None) -> Col |

Re: [PR] [SPARK-46654][SQL][Python] Make `to_csv` explicitly indicate that it does not support complex types of data [spark]

2024-03-10 Thread via GitHub
LuciferYang commented on code in PR #44665: URL: https://github.com/apache/spark/pull/44665#discussion_r1519047021 ## python/pyspark/sql/functions/builtin.py: ## @@ -15534,19 +15532,7 @@ def to_csv(col: "ColumnOrName", options: Optional[Dict[str, str]] = None) -> Col |

Re: [PR] [SPARK-46654][SQL][Python] Make `to_csv` explicitly indicate that it does not support complex types of data [spark]

2024-03-10 Thread via GitHub
MaxGekk commented on code in PR #44665: URL: https://github.com/apache/spark/pull/44665#discussion_r1518964720 ## python/pyspark/sql/functions/builtin.py: ## @@ -15534,19 +15532,7 @@ def to_csv(col: "ColumnOrName", options: Optional[Dict[str, str]] = None) -> Col |

Re: [PR] [SPARK-46654][SQL][Python] Make `to_csv` explicitly indicate that it does not support complex types of data [spark]

2024-03-07 Thread via GitHub
panbingkun commented on PR #44665: URL: https://github.com/apache/spark/pull/44665#issuecomment-1985106638 friendly ping @HyukjinKwon, When you are not busy, can you please continue to help review this PR? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [SPARK-46654][SQL][Python] Make `to_csv` explicitly indicate that it does not support complex types of data [spark]

2024-02-23 Thread via GitHub
panbingkun commented on PR #44665: URL: https://github.com/apache/spark/pull/44665#issuecomment-1961086132 > Is this considered a bug fix? Do we need to backport it to branch-3.5/3.4 Yea, I think we need to backport it to `branch-3.5/3.4`. -- This is an automated message from the

Re: [PR] [SPARK-46654][SQL][Python] Make `to_csv` explicitly indicate that it does not support complex types of data [spark]

2024-02-22 Thread via GitHub
LuciferYang commented on PR #44665: URL: https://github.com/apache/spark/pull/44665#issuecomment-1960689067 Is this considered a bug fix? Do we need to backport it to branch-3.5/3.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [SPARK-46654][SQL][Python] Make `to_csv` explicitly indicate that it does not support complex types of data [spark]

2024-02-22 Thread via GitHub
panbingkun commented on PR #44665: URL: https://github.com/apache/spark/pull/44665#issuecomment-1960618407 > Would you please add `[PYTHON]` to title considering it has user-facing python change? Thanks! Sure, done.  -- This is an automated message from the Apache Git Service. To

Re: [PR] [SPARK-46654][SQL][Python] Make `to_csv` explicitly indicate that it does not support complex types of data [spark]

2024-02-22 Thread via GitHub
panbingkun commented on code in PR #44665: URL: https://github.com/apache/spark/pull/44665#discussion_r1500137200 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala: ## @@ -260,16 +263,43 @@ case class StructsToCsv( child =