Re: [PR] [SPARK-46743][SQL] Count bug after constant folding [spark]

cloud-fan closed pull request #45125: [SPARK-46743][SQL] Count bug after constant folding URL: https://github.com/apache/spark/pull/45125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SPARK-46743][SQL] Count bug after constant folding [spark]

cloud-fan commented on PR #45125: URL: https://github.com/apache/spark/pull/45125#issuecomment-2018411588 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-46743][SQL] Count bug after constant folding [spark]

agubichev commented on code in PR #45125: URL: https://github.com/apache/spark/pull/45125#discussion_r1516770647 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteWithExpression.scala: ## @@ -34,7 +34,7 @@ import

Re: [PR] [SPARK-46743][SQL] Count bug after constant folding [spark]

jchen5 commented on code in PR #45125: URL: https://github.com/apache/spark/pull/45125#discussion_r1516503722 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteWithExpression.scala: ## @@ -34,7 +34,7 @@ import

Re: [PR] [SPARK-46743][SQL] Count bug after constant folding [spark]

cloud-fan commented on code in PR #45125: URL: https://github.com/apache/spark/pull/45125#discussion_r1515561516 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteWithExpression.scala: ## @@ -34,7 +34,7 @@ import

Re: [PR] [SPARK-46743][SQL] Count bug after constant folding [spark]

agubichev commented on code in PR #45125: URL: https://github.com/apache/spark/pull/45125#discussion_r1514771822 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteWithExpression.scala: ## @@ -34,7 +34,7 @@ import

Re: [PR] [SPARK-46743][SQL] Count bug after constant folding [spark]

agubichev commented on code in PR #45125: URL: https://github.com/apache/spark/pull/45125#discussion_r1514762032 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteWithExpression.scala: ## @@ -34,7 +34,7 @@ import

Re: [PR] [SPARK-46743][SQL] Count bug after constant folding [spark]

cloud-fan commented on code in PR #45125: URL: https://github.com/apache/spark/pull/45125#discussion_r1513701849 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteWithExpression.scala: ## @@ -34,7 +34,7 @@ import

Re: [PR] [SPARK-46743][SQL] Count bug after constant folding [spark]

cloud-fan commented on code in PR #45125: URL: https://github.com/apache/spark/pull/45125#discussion_r1513701628 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/RewriteWithExpression.scala: ## @@ -34,7 +34,7 @@ import

Re: [PR] [SPARK-46743][SQL] Count bug after constant folding [spark]

cloud-fan commented on code in PR #45125: URL: https://github.com/apache/spark/pull/45125#discussion_r1513701474 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala: ## @@ -328,6 +328,34 @@ abstract class Optimizer(catalogManager:

Re: [PR] [SPARK-46743][SQL] Count bug after constant folding [spark]

agubichev commented on code in PR #45125: URL: https://github.com/apache/spark/pull/45125#discussion_r1513262881 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala: ## @@ -328,6 +328,31 @@ abstract class Optimizer(catalogManager:

Re: [PR] [SPARK-46743][SQL] Count bug after constant folding [spark]

agubichev commented on code in PR #45125: URL: https://github.com/apache/spark/pull/45125#discussion_r1513261508 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala: ## @@ -328,6 +328,31 @@ abstract class Optimizer(catalogManager:

Re: [PR] [SPARK-46743][SQL] Count bug after constant folding [spark]

cloud-fan commented on code in PR #45125: URL: https://github.com/apache/spark/pull/45125#discussion_r1512183617 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala: ## @@ -328,6 +328,31 @@ abstract class Optimizer(catalogManager:

Re: [PR] [SPARK-46743][SQL] Count bug after constant folding [spark]

cloud-fan commented on code in PR #45125: URL: https://github.com/apache/spark/pull/45125#discussion_r1512181287 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala: ## @@ -328,6 +328,31 @@ abstract class Optimizer(catalogManager:

Re: [PR] [SPARK-46743][SQL] Count bug after constant folding [spark]

agubichev commented on PR #45125: URL: https://github.com/apache/spark/pull/45125#issuecomment-1977518691 > Thanks for the fix, looks good overall. > > Let's add a gating flag for this change just in case of any issues. added a flag -- This is an automated message from the

Re: [PR] [SPARK-46743][SQL] Count bug after constant folding [spark]

agubichev commented on PR #45125: URL: https://github.com/apache/spark/pull/45125#issuecomment-1977518871 @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SPARK-46743][SQL] Count bug after constant folding [spark]

agubichev commented on code in PR #45125: URL: https://github.com/apache/spark/pull/45125#discussion_r1511831412 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala: ## @@ -328,6 +328,30 @@ abstract class Optimizer(catalogManager:

Re: [PR] [SPARK-46743][SQL] Count bug after constant folding [spark]

agubichev commented on PR #45125: URL: https://github.com/apache/spark/pull/45125#issuecomment-1977503018 > What about if there's another node above the aggregate in the subquery, such as a filter after the aggregate (having clause)? added a test, but any non-trivial node about the

Re: [PR] [SPARK-46743][SQL] Count bug after constant folding [spark]

agubichev commented on code in PR #45125: URL: https://github.com/apache/spark/pull/45125#discussion_r1511830190 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala: ## @@ -328,6 +328,30 @@ abstract class Optimizer(catalogManager:

Re: [PR] [SPARK-46743][SQL] Count bug after constant folding [spark]

jchen5 commented on code in PR #45125: URL: https://github.com/apache/spark/pull/45125#discussion_r1498343024 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala: ## @@ -328,6 +328,30 @@ abstract class Optimizer(catalogManager: CatalogManager)