ahshahid commented on PR #45343:
URL: https://github.com/apache/spark/pull/45343#issuecomment-1996044845
The PR #45446 handles the issue comprehensively and this PR was a subset of
the changes contained in PR #45446 , so closing this PR
--
This is an automated message from the Apache Git
ahshahid closed pull request #45343: [SPARK-47217][SQL] Fix ambiguity check in
self joins
URL: https://github.com/apache/spark/pull/45343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ahshahid commented on code in PR #45343:
URL: https://github.com/apache/spark/pull/45343#discussion_r1522039397
##
sql/core/src/test/scala/org/apache/spark/sql/DataFrameSelfJoinSuite.scala:
##
@@ -498,4 +559,70 @@ class DataFrameSelfJoinSuite extends QueryTest with
ahshahid commented on code in PR #45343:
URL: https://github.com/apache/spark/pull/45343#discussion_r1522039397
##
sql/core/src/test/scala/org/apache/spark/sql/DataFrameSelfJoinSuite.scala:
##
@@ -498,4 +559,70 @@ class DataFrameSelfJoinSuite extends QueryTest with
peter-toth commented on code in PR #45343:
URL: https://github.com/apache/spark/pull/45343#discussion_r1521535582
##
sql/core/src/test/scala/org/apache/spark/sql/DataFrameSelfJoinSuite.scala:
##
@@ -498,4 +559,70 @@ class DataFrameSelfJoinSuite extends QueryTest with
peter-toth commented on code in PR #45343:
URL: https://github.com/apache/spark/pull/45343#discussion_r1521535582
##
sql/core/src/test/scala/org/apache/spark/sql/DataFrameSelfJoinSuite.scala:
##
@@ -498,4 +559,70 @@ class DataFrameSelfJoinSuite extends QueryTest with
ahshahid commented on code in PR #45343:
URL: https://github.com/apache/spark/pull/45343#discussion_r1520395436
##
sql/core/src/test/scala/org/apache/spark/sql/DataFrameSelfJoinSuite.scala:
##
@@ -498,4 +559,70 @@ class DataFrameSelfJoinSuite extends QueryTest with
ahshahid commented on code in PR #45343:
URL: https://github.com/apache/spark/pull/45343#discussion_r1520323348
##
sql/core/src/test/scala/org/apache/spark/sql/DataFrameSelfJoinSuite.scala:
##
@@ -498,4 +559,70 @@ class DataFrameSelfJoinSuite extends QueryTest with
ahshahid commented on code in PR #45343:
URL: https://github.com/apache/spark/pull/45343#discussion_r1520314613
##
sql/core/src/test/scala/org/apache/spark/sql/DataFrameSelfJoinSuite.scala:
##
@@ -498,4 +559,70 @@ class DataFrameSelfJoinSuite extends QueryTest with
peter-toth commented on code in PR #45343:
URL: https://github.com/apache/spark/pull/45343#discussion_r1520115101
##
sql/core/src/test/scala/org/apache/spark/sql/DataFrameSelfJoinSuite.scala:
##
@@ -498,4 +559,70 @@ class DataFrameSelfJoinSuite extends QueryTest with
peter-toth commented on code in PR #45343:
URL: https://github.com/apache/spark/pull/45343#discussion_r1520078411
##
sql/core/src/test/scala/org/apache/spark/sql/DataFrameSelfJoinSuite.scala:
##
@@ -498,4 +559,70 @@ class DataFrameSelfJoinSuite extends QueryTest with
peter-toth commented on code in PR #45343:
URL: https://github.com/apache/spark/pull/45343#discussion_r1520078411
##
sql/core/src/test/scala/org/apache/spark/sql/DataFrameSelfJoinSuite.scala:
##
@@ -498,4 +559,70 @@ class DataFrameSelfJoinSuite extends QueryTest with
peter-toth commented on code in PR #45343:
URL: https://github.com/apache/spark/pull/45343#discussion_r1520049076
##
sql/core/src/test/scala/org/apache/spark/sql/DataFrameSelfJoinSuite.scala:
##
@@ -498,4 +559,70 @@ class DataFrameSelfJoinSuite extends QueryTest with
13 matches
Mail list logo