Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

cloud-fan closed pull request #45368: [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT URL: https://github.com/apache/spark/pull/45368 -- This is an automated message from the Apache Git Service. To

Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

cloud-fan commented on PR #45368: URL: https://github.com/apache/spark/pull/45368#issuecomment-1985288340 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

panbingkun commented on code in PR #45368: URL: https://github.com/apache/spark/pull/45368#discussion_r1517406812 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ## @@ -84,28 +85,28 @@ class BasicInMemoryTableCatalog extends

Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

LuciferYang commented on code in PR #45368: URL: https://github.com/apache/spark/pull/45368#discussion_r1517123366 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ## @@ -84,28 +85,28 @@ class BasicInMemoryTableCatalog extends

Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

cloud-fan commented on code in PR #45368: URL: https://github.com/apache/spark/pull/45368#discussion_r1517121687 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ## @@ -84,28 +85,28 @@ class BasicInMemoryTableCatalog extends

Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

panbingkun commented on code in PR #45368: URL: https://github.com/apache/spark/pull/45368#discussion_r1515628066 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ## @@ -84,28 +85,28 @@ class BasicInMemoryTableCatalog extends

Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

LuciferYang commented on code in PR #45368: URL: https://github.com/apache/spark/pull/45368#discussion_r1515621179 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala: ## @@ -249,6 +241,16 @@ class V2SessionCatalog(catalog:

Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

LuciferYang commented on code in PR #45368: URL: https://github.com/apache/spark/pull/45368#discussion_r1515620693 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ## @@ -84,28 +85,28 @@ class BasicInMemoryTableCatalog extends

Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

LuciferYang commented on code in PR #45368: URL: https://github.com/apache/spark/pull/45368#discussion_r1515620693 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ## @@ -84,28 +85,28 @@ class BasicInMemoryTableCatalog extends

Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

panbingkun commented on code in PR #45368: URL: https://github.com/apache/spark/pull/45368#discussion_r1515616923 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ## @@ -84,28 +84,29 @@ class BasicInMemoryTableCatalog extends

Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

cloud-fan commented on code in PR #45368: URL: https://github.com/apache/spark/pull/45368#discussion_r1514536902 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ## @@ -84,28 +84,29 @@ class BasicInMemoryTableCatalog extends

Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

LuciferYang commented on code in PR #45368: URL: https://github.com/apache/spark/pull/45368#discussion_r1514474616 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ## @@ -84,28 +84,29 @@ class BasicInMemoryTableCatalog extends

Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

LuciferYang commented on code in PR #45368: URL: https://github.com/apache/spark/pull/45368#discussion_r1514474616 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ## @@ -84,28 +84,29 @@ class BasicInMemoryTableCatalog extends

Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

panbingkun commented on code in PR #45368: URL: https://github.com/apache/spark/pull/45368#discussion_r1514473565 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ## @@ -84,28 +84,29 @@ class BasicInMemoryTableCatalog extends

Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

cloud-fan commented on code in PR #45368: URL: https://github.com/apache/spark/pull/45368#discussion_r1514390687 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ## @@ -84,28 +84,29 @@ class BasicInMemoryTableCatalog extends

Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

panbingkun commented on code in PR #45368: URL: https://github.com/apache/spark/pull/45368#discussion_r1514278795 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ## @@ -84,28 +84,29 @@ class BasicInMemoryTableCatalog extends

Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

cloud-fan commented on code in PR #45368: URL: https://github.com/apache/spark/pull/45368#discussion_r1514121653 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala: ## @@ -249,6 +241,17 @@ class V2SessionCatalog(catalog:

Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

cloud-fan commented on code in PR #45368: URL: https://github.com/apache/spark/pull/45368#discussion_r1514118805 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryTableCatalog.scala: ## @@ -84,28 +84,29 @@ class BasicInMemoryTableCatalog extends

Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

panbingkun commented on code in PR #45368: URL: https://github.com/apache/spark/pull/45368#discussion_r1513941395 ## sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala: ## @@ -156,15 +156,6 @@ class V2SessionCatalog(catalog:

Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

cloud-fan commented on code in PR #45368: URL: https://github.com/apache/spark/pull/45368#discussion_r1512285216 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryRowLevelOperationTableCatalog.scala: ## @@ -31,13 +31,23 @@ class

Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

cloud-fan commented on code in PR #45368: URL: https://github.com/apache/spark/pull/45368#discussion_r1512284803 ## sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/InMemoryPartitionTableCatalog.scala: ## @@ -31,12 +31,22 @@ class InMemoryPartitionTableCatalog

Re: [PR] [SPARK-47265][SQL][TESTS] Replace `createTable(..., schema: StructType, ...)` with `createTable(..., columns: Array[Column], ...)` in UT [spark]

panbingkun commented on PR #45368: URL: https://github.com/apache/spark/pull/45368#issuecomment-1978003238 cc @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.