Re: [PR] [SPARK-47295][SQL][COLLATION] Added ICU StringSearch for 'startsWith' and 'endsWith' functions [spark]

2024-03-11 Thread via GitHub
stevomitric commented on code in PR #45421: URL: https://github.com/apache/spark/pull/45421#discussion_r1519971782 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -378,13 +378,6 @@ public boolean matchAt(final UTF8String s, int pos) {

Re: [PR] [SPARK-47295][SQL][COLLATION] Added ICU StringSearch for 'startsWith' and 'endsWith' functions [spark]

2024-03-11 Thread via GitHub
cloud-fan commented on code in PR #45421: URL: https://github.com/apache/spark/pull/45421#discussion_r1519546855 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -396,7 +389,18 @@ public boolean startsWith(final UTF8String prefix, int

Re: [PR] [SPARK-47295][SQL][COLLATION] Added ICU StringSearch for 'startsWith' and 'endsWith' functions [spark]

2024-03-11 Thread via GitHub
dbatomic commented on code in PR #45421: URL: https://github.com/apache/spark/pull/45421#discussion_r1519451854 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -396,7 +389,18 @@ public boolean startsWith(final UTF8String prefix, int

Re: [PR] [SPARK-47295][SQL][COLLATION] Added ICU StringSearch for 'startsWith' and 'endsWith' functions [spark]

2024-03-11 Thread via GitHub
uros-db commented on code in PR #45421: URL: https://github.com/apache/spark/pull/45421#discussion_r1519387286 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -378,13 +378,6 @@ public boolean matchAt(final UTF8String s, int pos) { return

Re: [PR] [SPARK-47295][SQL][COLLATION] Added ICU StringSearch for 'startsWith' and 'endsWith' functions [spark]

2024-03-11 Thread via GitHub
uros-db commented on code in PR #45421: URL: https://github.com/apache/spark/pull/45421#discussion_r1519387286 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -378,13 +378,6 @@ public boolean matchAt(final UTF8String s, int pos) { return

Re: [PR] [SPARK-47295][SQL][COLLATION] Added ICU StringSearch for 'startsWith' and 'endsWith' functions [spark]

2024-03-11 Thread via GitHub
uros-db commented on code in PR #45421: URL: https://github.com/apache/spark/pull/45421#discussion_r1519379776 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -396,7 +389,18 @@ public boolean startsWith(final UTF8String prefix, int

Re: [PR] [SPARK-47295][SQL][COLLATION] Added ICU StringSearch for 'startsWith' and 'endsWith' functions [spark]

2024-03-11 Thread via GitHub
MaxGekk commented on code in PR #45421: URL: https://github.com/apache/spark/pull/45421#discussion_r1519361693 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -378,13 +378,6 @@ public boolean matchAt(final UTF8String s, int pos) { return

Re: [PR] [SPARK-47295][SQL][COLLATION] Added ICU StringSearch for 'startsWith' and 'endsWith' functions [spark]

2024-03-11 Thread via GitHub
uros-db commented on code in PR #45421: URL: https://github.com/apache/spark/pull/45421#discussion_r1519302246 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -396,7 +389,18 @@ public boolean startsWith(final UTF8String prefix, int

Re: [PR] [SPARK-47295][SQL][COLLATION] Added ICU StringSearch for 'startsWith' and 'endsWith' functions [spark]

2024-03-11 Thread via GitHub
uros-db commented on code in PR #45421: URL: https://github.com/apache/spark/pull/45421#discussion_r1519302618 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -410,7 +414,20 @@ public boolean endsWith(final UTF8String suffix, int

Re: [PR] [SPARK-47295][SQL][COLLATION] Added ICU StringSearch for 'startsWith' and 'endsWith' functions [spark]

2024-03-09 Thread via GitHub
stevomitric commented on code in PR #45421: URL: https://github.com/apache/spark/pull/45421#discussion_r1518576388 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -410,7 +414,19 @@ public boolean endsWith(final UTF8String suffix, int

Re: [PR] [SPARK-47295][SQL][COLLATION] Added ICU StringSearch for 'startsWith' and 'endsWith' functions [spark]

2024-03-08 Thread via GitHub
uros-db commented on code in PR #45421: URL: https://github.com/apache/spark/pull/45421#discussion_r1518050657 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -410,7 +414,19 @@ public boolean endsWith(final UTF8String suffix, int

Re: [PR] [SPARK-47295][SQL][COLLATION] Added ICU StringSearch for 'startsWith' and 'endsWith' functions [spark]

2024-03-08 Thread via GitHub
dbatomic commented on code in PR #45421: URL: https://github.com/apache/spark/pull/45421#discussion_r1517978032 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -410,7 +414,19 @@ public boolean endsWith(final UTF8String suffix, int

Re: [PR] [SPARK-47295][SQL][COLLATION] Added ICU StringSearch for 'startsWith' and 'endsWith' functions [spark]

2024-03-08 Thread via GitHub
dbatomic commented on code in PR #45421: URL: https://github.com/apache/spark/pull/45421#discussion_r1517976807 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -410,7 +414,19 @@ public boolean endsWith(final UTF8String suffix, int

Re: [PR] [SPARK-47295][SQL][COLLATION] Added ICU StringSearch for 'startsWith' and 'endsWith' functions [spark]

2024-03-08 Thread via GitHub
dbatomic commented on code in PR #45421: URL: https://github.com/apache/spark/pull/45421#discussion_r1517975311 ## common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java: ## @@ -410,7 +414,19 @@ public boolean endsWith(final UTF8String suffix, int