Re: [PR] [SPARK-47302][SQL][Collation] Collate keyword as identifier [spark]

stefankandic commented on code in PR #45405: URL: https://github.com/apache/spark/pull/45405#discussion_r1516535896 ## sql/api/src/main/scala/org/apache/spark/sql/types/DataType.scala: ## @@ -117,7 +117,7 @@ object DataType { private val FIXED_DECIMAL =

Re: [PR] [SPARK-47302][SQL][Collation] Collate keyword as identifier [spark]

MaxGekk commented on code in PR #45405: URL: https://github.com/apache/spark/pull/45405#discussion_r1516378011 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -1096,7 +1096,7 @@ colPosition ; collateClause -: COLLATE

Re: [PR] [SPARK-47302][SQL][Collation] Collate keyword as identifier [spark]

MaxGekk commented on code in PR #45405: URL: https://github.com/apache/spark/pull/45405#discussion_r1516415830 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -1096,7 +1096,7 @@ colPosition ; collateClause -: COLLATE

Re: [PR] [SPARK-47302][SQL][Collation] Collate keyword as identifier [spark]

stefankandic commented on code in PR #45405: URL: https://github.com/apache/spark/pull/45405#discussion_r1516396458 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -1096,7 +1096,7 @@ colPosition ; collateClause -: COLLATE

Re: [PR] [SPARK-47302][SQL][Collation] Collate keyword as identifier [spark]

stefankandic commented on code in PR #45405: URL: https://github.com/apache/spark/pull/45405#discussion_r1516396458 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -1096,7 +1096,7 @@ colPosition ; collateClause -: COLLATE

Re: [PR] [SPARK-47302][SQL][Collation] Collate keyword as identifier [spark]

MaxGekk commented on code in PR #45405: URL: https://github.com/apache/spark/pull/45405#discussion_r1516378011 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -1096,7 +1096,7 @@ colPosition ; collateClause -: COLLATE

Re: [PR] [SPARK-47302][SQL][Collation] Collate keyword as identifier [spark]

MaxGekk commented on code in PR #45405: URL: https://github.com/apache/spark/pull/45405#discussion_r1516373801 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -1096,7 +1096,7 @@ colPosition ; collateClause -: COLLATE

Re: [PR] [SPARK-47302][SQL][Collation] Collate keyword as identifier [spark]

stefankandic commented on code in PR #45405: URL: https://github.com/apache/spark/pull/45405#discussion_r1516357243 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -1096,7 +1096,7 @@ colPosition ; collateClause -: COLLATE

Re: [PR] [SPARK-47302][SQL][Collation] Collate keyword as identifier [spark]

MaxGekk commented on code in PR #45405: URL: https://github.com/apache/spark/pull/45405#discussion_r1516070311 ## sql/api/src/main/scala/org/apache/spark/sql/types/DataType.scala: ## @@ -117,7 +117,7 @@ object DataType { private val FIXED_DECIMAL =

Re: [PR] [SPARK-47302][SQL][Collation] Collate keyword as identifier [spark]

MaxGekk commented on code in PR #45405: URL: https://github.com/apache/spark/pull/45405#discussion_r1516062859 ## sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4: ## @@ -1096,7 +1096,7 @@ colPosition ; collateClause -: COLLATE

Re: [PR] [SPARK-47302][SQL][Collation] Collate keyword as identifier [spark]

dbatomic commented on code in PR #45405: URL: https://github.com/apache/spark/pull/45405#discussion_r1515984970 ## python/pyspark/sql/tests/test_types.py: ## @@ -862,15 +862,13 @@ def test_parse_datatype_string(self): if k != "varchar" and k != "char":

Re: [PR] [SPARK-47302][SQL][Collation] Collate keyword as identifier [spark]

dbatomic commented on code in PR #45405: URL: https://github.com/apache/spark/pull/45405#discussion_r1515983493 ## sql/api/src/main/scala/org/apache/spark/sql/catalyst/parser/DataTypeAstBuilder.scala: ## @@ -218,6 +218,6 @@ class DataTypeAstBuilder extends