Re: [PR] [SPARK-47307][SQL] Add a config to optionally chunk base64 strings [spark]

dongjoon-hyun commented on PR #45408: URL: https://github.com/apache/spark/pull/45408#issuecomment-2098956928 Gentle ping, @ted-jenks . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SPARK-47307][SQL] Add a config to optionally chunk base64 strings [spark]

yaooqinn commented on PR #45408: URL: https://github.com/apache/spark/pull/45408#issuecomment-2008724931 Gentle ping @ted-jenks, any updates for the test failures? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [SPARK-47307][SQL] Add a config to optionally chunk base64 strings [spark]

dongjoon-hyun commented on code in PR #45408: URL: https://github.com/apache/spark/pull/45408#discussion_r1522057774 ## sql/core/src/test/resources/sql-tests/results/charvarchar.sql.out: ## @@ -839,17 +839,26 @@ NULL NULLNULLNULL -- !query select base64(c7),

Re: [PR] [SPARK-47307][SQL] Add a config to optionally chunk base64 strings [spark]

dongjoon-hyun commented on code in PR #45408: URL: https://github.com/apache/spark/pull/45408#discussion_r1522057496 ## sql/core/src/test/resources/sql-tests/analyzer-results/charvarchar.sql.out: ## @@ -458,10 +458,24 @@ Project [ascii(c7#x) AS ascii(c7)#x, ascii(c8#x) AS

Re: [PR] [SPARK-47307][SQL] Add a config to optionally chunk base64 strings [spark]

dongjoon-hyun commented on PR #45408: URL: https://github.com/apache/spark/pull/45408#issuecomment-1989116494 Could you do the following to re-generate the golden files, @ted-jenks ? ``` SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite"

Re: [PR] [SPARK-47307][SQL] Add a config to optionally chunk base64 strings [spark]

ted-jenks commented on PR #45408: URL: https://github.com/apache/spark/pull/45408#issuecomment-1988639946 I am having trouble getting the failing test to pass: ```13:27:04.051 ERROR org.apache.spark.sql.hive.thriftserver.ThriftServerQueryTestSuite``` Giving: ```

Re: [PR] [SPARK-47307][SQL] Add a config to optionally chunk base64 strings [spark]

yaooqinn commented on PR #45408: URL: https://github.com/apache/spark/pull/45408#issuecomment-1988397848 thank you for the explanation @ted-jenks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [SPARK-47307][SQL] Add a config to optionally chunk base64 strings [spark]

ted-jenks commented on PR #45408: URL: https://github.com/apache/spark/pull/45408#issuecomment-1988371956 > Do we need to revise unbase64 accordingly? Unbase64 uses the Mime decoder, which can tolerate chunked and unchunked data. -- This is an automated message from the Apache

Re: [PR] [SPARK-47307][SQL] Add a config to optionally chunk base64 strings [spark]

yaooqinn commented on PR #45408: URL: https://github.com/apache/spark/pull/45408#issuecomment-1988293451 Do we need to revise unbase64 accordingly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go