Re: [PR] [SPARK-47314][DOC] Correct the `ExternalSorter#writePartitionedMapOutput` method comment [spark]

2024-03-07 Thread via GitHub
zwangsheng commented on code in PR #45415: URL: https://github.com/apache/spark/pull/45415#discussion_r1517066704 ## core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala: ## @@ -690,7 +690,7 @@ private[spark] class ExternalSorter[K, V, C]( * Write all

Re: [PR] [SPARK-47314][DOC] Correct the `ExternalSorter#writePartitionedMapOutput` method comment [spark]

2024-03-07 Thread via GitHub
LuciferYang commented on code in PR #45415: URL: https://github.com/apache/spark/pull/45415#discussion_r1516106051 ## core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala: ## @@ -690,7 +690,7 @@ private[spark] class ExternalSorter[K, V, C]( * Write all

Re: [PR] [SPARK-47314][DOC] Correct the `ExternalSorter#writePartitionedMapOutput` method comment [spark]

2024-03-07 Thread via GitHub
yaooqinn commented on code in PR #45415: URL: https://github.com/apache/spark/pull/45415#discussion_r1515746618 ## core/src/main/scala/org/apache/spark/util/collection/ExternalSorter.scala: ## @@ -690,7 +690,7 @@ private[spark] class ExternalSorter[K, V, C]( * Write all the

Re: [PR] [SPARK-47314][DOC] Correct the `ExternalSorter#writePartitionedMapOutput` method comment [spark]

2024-03-06 Thread via GitHub
zwangsheng commented on PR #45415: URL: https://github.com/apache/spark/pull/45415#issuecomment-1982290244 Hi @mridulm @yaooqinn @mccheah, aims to correct the comment, please take a review, thanks. -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] [SPARK-47314][DOC] Correct the `ExternalSorter#writePartitionedMapOutput` method comment [spark]

2024-03-06 Thread via GitHub
zwangsheng opened a new pull request, #45415: URL: https://github.com/apache/spark/pull/45415 ### What changes were proposed in this pull request? Correct the comment of `ExternalSorter#writePartitionedMapOutput`. `ExternalSorter#writePartitionedMapOutput` return nothing, and will