Re: [PR] [SPARK-47327][SQL] Fix thread safety issue in ICU Collator [spark]

HyukjinKwon closed pull request #45436: [SPARK-47327][SQL] Fix thread safety issue in ICU Collator URL: https://github.com/apache/spark/pull/45436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [SPARK-47327][SQL] Fix thread safety issue in ICU Collator [spark]

HyukjinKwon commented on PR #45436: URL: https://github.com/apache/spark/pull/45436#issuecomment-1989650161 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-47327][SQL] Fix thread safety issue in ICU Collator [spark]

dbatomic commented on code in PR #45436: URL: https://github.com/apache/spark/pull/45436#discussion_r1519437339 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -138,11 +138,13 @@ public Collation( collationTable[2] = new

Re: [PR] [SPARK-47327][SQL] Fix thread safety issue in ICU Collator [spark]

cloud-fan commented on code in PR #45436: URL: https://github.com/apache/spark/pull/45436#discussion_r1519395144 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -138,11 +138,13 @@ public Collation( collationTable[2] = new

Re: [PR] [SPARK-47327][SQL] Fix thread safety issue in ICU Collator [spark]

stefankandic commented on code in PR #45436: URL: https://github.com/apache/spark/pull/45436#discussion_r1519361380 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -138,11 +138,13 @@ public Collation( collationTable[2] = new

Re: [PR] [SPARK-47327][SQL] Fix thread safety issue in ICU Collator [spark]

stefankandic commented on code in PR #45436: URL: https://github.com/apache/spark/pull/45436#discussion_r1519362819 ## sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala: ## @@ -438,6 +439,19 @@ class CollationSuite extends DatasourceV2SQLBase with

Re: [PR] [SPARK-47327][SQL] Fix thread safety issue in ICU Collator [spark]

stefankandic commented on code in PR #45436: URL: https://github.com/apache/spark/pull/45436#discussion_r1519361380 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -138,11 +138,13 @@ public Collation( collationTable[2] = new

Re: [PR] [SPARK-47327][SQL] Fix thread safety issue in ICU Collator [spark]

dbatomic commented on code in PR #45436: URL: https://github.com/apache/spark/pull/45436#discussion_r1519347155 ## sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala: ## @@ -438,6 +439,19 @@ class CollationSuite extends DatasourceV2SQLBase with

Re: [PR] [SPARK-47327][SQL] Fix thread safety issue in ICU Collator [spark]

cloud-fan commented on code in PR #45436: URL: https://github.com/apache/spark/pull/45436#discussion_r1519141471 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -138,11 +138,13 @@ public Collation( collationTable[2] = new

Re: [PR] [SPARK-47327][SQL] Fix thread safety issue in ICU Collator [spark]

stefankandic commented on code in PR #45436: URL: https://github.com/apache/spark/pull/45436#discussion_r1518248868 ## sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala: ## @@ -438,6 +438,39 @@ class CollationSuite extends DatasourceV2SQLBase with

Re: [PR] [SPARK-47327][SQL] Fix thread safety issue in ICU Collator [spark]

MaxGekk commented on code in PR #45436: URL: https://github.com/apache/spark/pull/45436#discussion_r1518208382 ## sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala: ## @@ -438,6 +438,39 @@ class CollationSuite extends DatasourceV2SQLBase with

Re: [PR] [SPARK-47327][SQL] Fix thread safety issue in ICU Collator [spark]

uros-db commented on code in PR #45436: URL: https://github.com/apache/spark/pull/45436#discussion_r1518059723 ## sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala: ## @@ -438,6 +438,39 @@ class CollationSuite extends DatasourceV2SQLBase with

Re: [PR] [SPARK-47327][SQL] Fix thread safety issue in ICU Collator [spark]

uros-db commented on code in PR #45436: URL: https://github.com/apache/spark/pull/45436#discussion_r1518058827 ## sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala: ## @@ -438,6 +438,39 @@ class CollationSuite extends DatasourceV2SQLBase with

Re: [PR] [SPARK-47327][SQL] Fix thread safety issue in ICU Collator [spark]

uros-db commented on code in PR #45436: URL: https://github.com/apache/spark/pull/45436#discussion_r1518055476 ## common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java: ## @@ -138,11 +138,13 @@ public Collation( collationTable[2] = new

[PR] [SPARK-47327][SQL] Fix thread safety issue in ICU Collator [spark]

stefankandic opened a new pull request, #45436: URL: https://github.com/apache/spark/pull/45436 ### What changes were proposed in this pull request? Freezing the ICU collator upon creation. ### Why are the changes needed? In order to get correct results when