srielau commented on code in PR #45462:
URL: https://github.com/apache/spark/pull/45462#discussion_r1523678372
##
common/utils/src/main/resources/error/error-classes.json:
##
@@ -3004,6 +3004,12 @@
],
"sqlState" : "2200E"
},
+ "NULL_QUERY_STRING_EXECUTE_IMMEDIATE"
MaxGekk closed pull request #45462: [SPARK-47343][SQL] Fix NPE when `sqlString`
variable value is null string in execute immediate
URL: https://github.com/apache/spark/pull/45462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
MaxGekk commented on PR #45462:
URL: https://github.com/apache/spark/pull/45462#issuecomment-1991435342
+1, LGTM. Merging to master.
Thank you, @stefanbuk-db and @milastdbx for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
MaxGekk commented on PR #45462:
URL: https://github.com/apache/spark/pull/45462#issuecomment-1991433598
The failed test:
```
[info] OracleIntegrationSuite:
...
[info] Cause: oracle.net.ns.NetException: ORA-12541: Cannot connect. No
listener at host 10.1.1.146 port 46609.
milastdbx commented on code in PR #45462:
URL: https://github.com/apache/spark/pull/45462#discussion_r1521059360
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/executeImmediate.scala:
##
@@ -88,10 +88,16 @@ class SubstituteExecuteImmediate(val
milastdbx commented on code in PR #45462:
URL: https://github.com/apache/spark/pull/45462#discussion_r1521058729
##
common/utils/src/main/resources/error/error-classes.json:
##
@@ -3004,6 +3004,12 @@
],
"sqlState" : "2200E"
},
+
MaxGekk commented on code in PR #45462:
URL: https://github.com/apache/spark/pull/45462#discussion_r1520631768
##
common/utils/src/main/resources/error/error-classes.json:
##
@@ -3004,6 +3004,12 @@
],
"sqlState" : "2200E"
},
+ "NULL_QUERY_STRING_EXECUTE_IMMEDIATE"
milastdbx commented on code in PR #45462:
URL: https://github.com/apache/spark/pull/45462#discussion_r1519779866
##
common/utils/src/main/resources/error/error-classes.json:
##
@@ -3004,6 +3004,12 @@
],
"sqlState" : "2200E"
},
+
