Re: [PR] [WIP][SPARK-47254][SQL] Assign names to the error classes _LEGACY_ERROR_TEMP_325[1-9] [spark]

MaxGekk commented on code in PR #45407: URL: https://github.com/apache/spark/pull/45407#discussion_r1519942137 ## sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkIntervalUtils.scala: ## @@ -131,24 +131,21 @@ trait SparkIntervalUtils { */ def

Re: [PR] [WIP][SPARK-47254][SQL] Assign names to the error classes _LEGACY_ERROR_TEMP_325[1-9] [spark]

stefanbuk-db commented on code in PR #45407: URL: https://github.com/apache/spark/pull/45407#discussion_r1519220632 ## sql/api/src/main/scala/org/apache/spark/sql/catalyst/util/SparkIntervalUtils.scala: ## @@ -229,13 +237,21 @@ trait SparkIntervalUtils { try {

Re: [PR] [WIP][SPARK-47254][SQL] Assign names to the error classes _LEGACY_ERROR_TEMP_325[1-9] [spark]

stefanbuk-db commented on code in PR #45407: URL: https://github.com/apache/spark/pull/45407#discussion_r1519209532 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -2060,6 +2085,74 @@ }, "sqlState" : "42000" }, + "INVALID_INTERVAL_FORMAT" : { +

Re: [PR] [WIP][SPARK-47254][SQL] Assign names to the error classes _LEGACY_ERROR_TEMP_325[1-9] [spark]

stefanbuk-db commented on code in PR #45407: URL: https://github.com/apache/spark/pull/45407#discussion_r1519208459 ## sql/api/src/main/scala/org/apache/spark/sql/types/StructType.scala: ## @@ -283,10 +283,10 @@ case class StructType(fields: Array[StructField]) extends

Re: [PR] [WIP][SPARK-47254][SQL] Assign names to the error classes _LEGACY_ERROR_TEMP_325[1-9] [spark]

stefanbuk-db commented on code in PR #45407: URL: https://github.com/apache/spark/pull/45407#discussion_r1519208319 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -1823,6 +1830,24 @@ }, "sqlState" : "HY109" }, + "INVALID_DATETIME_PATTERN" : { +

Re: [PR] [WIP][SPARK-47254][SQL] Assign names to the error classes _LEGACY_ERROR_TEMP_325[1-9] [spark]

MaxGekk commented on code in PR #45407: URL: https://github.com/apache/spark/pull/45407#discussion_r1518212624 ## sql/api/src/main/scala/org/apache/spark/sql/types/StructType.scala: ## @@ -316,10 +316,10 @@ case class StructType(fields: Array[StructField]) extends DataType

Re: [PR] [WIP][SPARK-47254][SQL] Assign names to the error classes _LEGACY_ERROR_TEMP_325[1-9] [spark]

stefanbuk-db commented on code in PR #45407: URL: https://github.com/apache/spark/pull/45407#discussion_r1517488703 ## sql/core/src/test/resources/sql-tests/results/interval.sql.out: ## @@ -1266,19 +1266,14 @@ select interval 10 nanoseconds -- !query schema struct<> --

Re: [PR] [WIP][SPARK-47254][SQL] Assign names to the error classes _LEGACY_ERROR_TEMP_325[1-9] [spark]

stefanbuk-db commented on code in PR #45407: URL: https://github.com/apache/spark/pull/45407#discussion_r1517477382 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -2807,6 +2844,24 @@ ], "sqlState" : "07501" }, +

Re: [PR] [WIP][SPARK-47254][SQL] Assign names to the error classes _LEGACY_ERROR_TEMP_325[1-9] [spark]

stefanbuk-db commented on code in PR #45407: URL: https://github.com/apache/spark/pull/45407#discussion_r1517476444 ## sql/core/src/test/resources/sql-tests/results/datetime-formatting-invalid.sql.out: ## @@ -500,7 +506,8 @@ struct<> -- !query output

Re: [PR] [WIP][SPARK-47254][SQL] Assign names to the error classes _LEGACY_ERROR_TEMP_325[1-9] [spark]

stefanbuk-db commented on code in PR #45407: URL: https://github.com/apache/spark/pull/45407#discussion_r1517475297 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -1770,6 +1777,12 @@ ], "sqlState" : "22P03" }, +

Re: [PR] [WIP][SPARK-47254][SQL] Assign names to the error classes _LEGACY_ERROR_TEMP_325[1-9] [spark]

stefanbuk-db commented on code in PR #45407: URL: https://github.com/apache/spark/pull/45407#discussion_r1517474681 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -1823,6 +1836,18 @@ }, "sqlState" : "HY109" }, + "INVALID_DATETIME_PATTERN" : { +

Re: [PR] [WIP][SPARK-47254][SQL] Assign names to the error classes _LEGACY_ERROR_TEMP_325[1-9] [spark]

stefanbuk-db commented on code in PR #45407: URL: https://github.com/apache/spark/pull/45407#discussion_r1517474227 ## sql/core/src/test/resources/sql-tests/results/datetime-formatting-invalid.sql.out: ## @@ -40,7 +40,8 @@ struct<> -- !query output

Re: [PR] [WIP][SPARK-47254][SQL] Assign names to the error classes _LEGACY_ERROR_TEMP_325[1-9] [spark]

stefanbuk-db commented on code in PR #45407: URL: https://github.com/apache/spark/pull/45407#discussion_r1517456249 ## common/utils/src/main/resources/error/error-classes.json: ## @@ -2060,6 +2085,12 @@ }, "sqlState" : "42000" }, + "INVALID_INTERVAL_FORMAT" : { +

Re: [PR] [WIP][SPARK-47254][SQL] Assign names to the error classes _LEGACY_ERROR_TEMP_325[1-9] [spark]

stefanbuk-db commented on code in PR #45407: URL: https://github.com/apache/spark/pull/45407#discussion_r1517455237 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala: ## @@ -455,19 +455,6 @@ class DDLParserSuite extends AnalysisTest with