HyukjinKwon closed pull request #46391: [SPARK-48045][PYTHON] Pandas API
groupby with multi-agg-relabel ignores as_index=False
URL: https://github.com/apache/spark/pull/46391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
HyukjinKwon commented on PR #46391:
URL: https://github.com/apache/spark/pull/46391#issuecomment-2099529188
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
itholic commented on code in PR #46391:
URL: https://github.com/apache/spark/pull/46391#discussion_r1593236433
##
python/pyspark/pandas/groupby.py:
##
@@ -308,6 +308,7 @@ def aggregate(
)
if not self._as_index:
+index_cols =
sinaiamonkar-sai commented on code in PR #46391:
URL: https://github.com/apache/spark/pull/46391#discussion_r1592518229
##
python/pyspark/pandas/groupby.py:
##
@@ -322,8 +323,12 @@ def aggregate(
psdf = psdf.reset_index(level=should_drop_index, drop=drop)
sinaiamonkar-sai commented on code in PR #46391:
URL: https://github.com/apache/spark/pull/46391#discussion_r1592517040
##
python/pyspark/pandas/groupby.py:
##
@@ -308,6 +308,7 @@ def aggregate(
)
if not self._as_index:
+index_cols =
itholic commented on code in PR #46391:
URL: https://github.com/apache/spark/pull/46391#discussion_r1591930032
##
python/pyspark/pandas/groupby.py:
##
@@ -308,6 +308,7 @@ def aggregate(
)
if not self._as_index:
+index_cols =
sinaiamonkar-sai commented on PR #46391:
URL: https://github.com/apache/spark/pull/46391#issuecomment-2095018053
Thank you @dongjoon-hyun! Sure, let me add that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
HyukjinKwon commented on PR #46391:
URL: https://github.com/apache/spark/pull/46391#issuecomment-2095016743
cc @itholic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sinaiamonkar-sai commented on PR #46391:
URL: https://github.com/apache/spark/pull/46391#issuecomment-2094885603
Hello, @holdenk ! This is my first Spark PR. Can you please review it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to