HyukjinKwon commented on PR #46408:
URL: https://github.com/apache/spark/pull/46408#issuecomment-2103609498
btw you can trigger on your own
https://github.com/eric-maynard/spark/runs/24789350525 I can't trigger :-).
--
This is an automated message from the Apache Git Service.
To respond
HyukjinKwon closed pull request #46408: [SPARK-48148][CORE] JSON objects should
not be modified when read as STRING
URL: https://github.com/apache/spark/pull/46408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
HyukjinKwon commented on PR #46408:
URL: https://github.com/apache/spark/pull/46408#issuecomment-2103609100
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
eric-maynard commented on PR #46408:
URL: https://github.com/apache/spark/pull/46408#issuecomment-2103174421
Hey @HyukjinKwon, can you take another look and possible re-trigger tests? I
believe multiline should be working now.
--
This is an automated message from the Apache Git Service.
eric-maynard commented on code in PR #46408:
URL: https://github.com/apache/spark/pull/46408#discussion_r1595695553
##
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala:
##
@@ -3900,26 +3900,26 @@ abstract class JsonSuite
}
HyukjinKwon commented on PR #46408:
URL: https://github.com/apache/spark/pull/46408#issuecomment-2101842606
```
SPARK-48148: values are unchanged when read as string *** FAILED *** (134
milliseconds)
```
seems it fails
--
This is an automated message from the Apache Git
HyukjinKwon commented on code in PR #46408:
URL: https://github.com/apache/spark/pull/46408#discussion_r1594851880
##
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala:
##
@@ -3865,6 +3865,65 @@ abstract class JsonSuite
}
}
}
HyukjinKwon commented on code in PR #46408:
URL: https://github.com/apache/spark/pull/46408#discussion_r1594852087
##
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala:
##
@@ -3865,6 +3865,65 @@ abstract class JsonSuite
}
}
}
HyukjinKwon commented on code in PR #46408:
URL: https://github.com/apache/spark/pull/46408#discussion_r1594852326
##
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala:
##
@@ -3865,6 +3865,65 @@ abstract class JsonSuite
}
}
}
HyukjinKwon commented on code in PR #46408:
URL: https://github.com/apache/spark/pull/46408#discussion_r1594851819
##
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala:
##
@@ -3865,6 +3865,65 @@ abstract class JsonSuite
}
}
}
eric-maynard commented on code in PR #46408:
URL: https://github.com/apache/spark/pull/46408#discussion_r1594623695
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala:
##
@@ -280,13 +280,32 @@ class JacksonParser(
case VALUE_STRING =>
eric-maynard commented on code in PR #46408:
URL: https://github.com/apache/spark/pull/46408#discussion_r1594767881
##
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala:
##
@@ -3865,6 +3865,24 @@ abstract class JsonSuite
}
}
eric-maynard commented on code in PR #46408:
URL: https://github.com/apache/spark/pull/46408#discussion_r1594623260
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala:
##
@@ -280,13 +280,32 @@ class JacksonParser(
case VALUE_STRING =>
sadikovi commented on code in PR #46408:
URL: https://github.com/apache/spark/pull/46408#discussion_r1594580639
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala:
##
@@ -280,13 +280,32 @@ class JacksonParser(
case VALUE_STRING =>
sadikovi commented on PR #46408:
URL: https://github.com/apache/spark/pull/46408#issuecomment-2101372332
cc @dongjoon-hyun @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
eric-maynard commented on code in PR #46408:
URL: https://github.com/apache/spark/pull/46408#discussion_r1591615927
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala:
##
@@ -280,13 +280,32 @@ class JacksonParser(
case VALUE_STRING =>
16 matches
Mail list logo