[GitHub] spark pull request: [SPARK-11549][Docs] Replace example code in ml...

2015-11-19 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/9689#discussion_r45318085 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/MultiLabelMetricsExample.scala --- @@ -0,0 +1,70 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-11549][Docs] Replace example code in ml...

2015-11-19 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/9689#discussion_r45318093 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/MultiLabelMetricsExample.scala --- @@ -0,0 +1,70 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-11549][Docs] Replace example code in ml...

2015-11-19 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/9689#discussion_r45318144 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/BinaryClassificationMetricsExample.scala --- @@ -0,0 +1,106 @@ +/* + * Licensed

[GitHub] spark pull request: [SPARK-11549][Docs] Replace example code in ml...

2015-11-19 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/9689#discussion_r45318073 --- Diff: examples/src/main/scala/org/apache/spark/examples/mllib/MultiLabelMetricsExample.scala --- @@ -0,0 +1,70 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-11549][Docs] Replace example code in ml...

2015-11-19 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/9689#discussion_r45318439 --- Diff: examples/src/main/python/mllib/regression_metrics_example.py --- @@ -0,0 +1,59 @@ +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-11549][Docs] Replace example code in ml...

2015-11-19 Thread yinxusen
Github user yinxusen commented on a diff in the pull request: https://github.com/apache/spark/pull/9689#discussion_r45318539 --- Diff: examples/src/main/python/mllib/ranking_metrics_example.py --- @@ -0,0 +1,55 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request: [SPARK-11848][SQL] Support EXPLAIN in DataSet ...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9832#issuecomment-158007674 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11848][SQL] Support EXPLAIN in DataSet ...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9832#issuecomment-158007430 **[Test build #46318 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46318/consoleFull)** for PR 9832 at commit

[GitHub] spark pull request: [SPARK-8546] Add PMML export for Naive Bayes

2015-11-19 Thread yinxusen
Github user yinxusen commented on the pull request: https://github.com/apache/spark/pull/9057#issuecomment-158013196 @mengxr How do you think about the PMML export for Multinomial Naive Bayes? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...

2015-11-19 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158172649 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-11812] [PySpark] invFunc=None works pro...

2015-11-19 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9775#issuecomment-158173975 @andrewor14 could you help trigger Jenkins? Thanks. I think I don't have the permission :( --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-11837] [EC2] python3 compatibility for ...

2015-11-19 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/9797#discussion_r45389631 --- Diff: ec2/spark_ec2.py --- @@ -591,11 +591,15 @@ def launch_cluster(conn, opts, cluster_name): # AWS ignores the AMI-specified block

[GitHub] spark pull request: [SPARK-11812] [PySpark] invFunc=None works pro...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9775#issuecomment-158174560 that's odd, you should have permission. retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158174906 **[Test build #46345 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46345/consoleFull)** for PR 9696 at commit

[GitHub] spark pull request: [SPARK-11636][SQL] Support classes defined in ...

2015-11-19 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9825#discussion_r45391437 --- Diff: repl/scala-2.10/src/main/scala/org/apache/spark/repl/SparkIMain.scala --- @@ -1221,10 +1221,16 @@ import org.apache.spark.annotation.DeveloperApi

[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158175789 **[Test build #46345 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46345/consoleFull)** for PR 9696 at commit

[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158175801 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-8641][SQL] Native Spark Window function...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9819#issuecomment-158175847 **[Test build #46346 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46346/consoleFull)** for PR 9819 at commit

[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158175805 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11812] [PySpark] invFunc=None works pro...

2015-11-19 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9775#issuecomment-158176063 this is ok to test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11636][SQL] Support classes defined in ...

2015-11-19 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9825#discussion_r45391606 --- Diff: repl/scala-2.10/src/test/scala/org/apache/spark/repl/ReplSuite.scala --- @@ -278,6 +281,27 @@ class ReplSuite extends SparkFunSuite {

[GitHub] spark pull request: [SPARK-11858][SQL] Move sql.columnar into sql....

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9842#issuecomment-158177608 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11858][SQL] Move sql.columnar into sql....

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9842#issuecomment-158177602 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9826#issuecomment-158177674 **[Test build #46343 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46343/consoleFull)** for PR 9826 at commit

[GitHub] spark pull request: [SPARK-11858][SQL] Move sql.columnar into sql....

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9842#issuecomment-158177491 **[Test build #46344 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46344/consoleFull)** for PR 9842 at commit

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9826#issuecomment-158178053 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11830][Core]Make NettyRpcEnv bind to th...

2015-11-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9821#issuecomment-158177951 Thanks - merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11819][SQL] nice error message for miss...

2015-11-19 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9810#discussion_r45392078 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -607,6 +607,89 @@ object ScalaReflection extends

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9826#issuecomment-158178060 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11819][SQL] nice error message for miss...

2015-11-19 Thread marmbrus
Github user marmbrus commented on a diff in the pull request: https://github.com/apache/spark/pull/9810#discussion_r45392361 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala --- @@ -607,6 +607,89 @@ object ScalaReflection extends

[GitHub] spark pull request: [SPARK-11830][Core]Make NettyRpcEnv bind to th...

2015-11-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9821 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11832] [Core] Process arguments in spar...

2015-11-19 Thread jodersky
Github user jodersky commented on a diff in the pull request: https://github.com/apache/spark/pull/9824#discussion_r45379122 --- Diff: repl/scala-2.11/src/main/scala/org/apache/spark/repl/Main.scala --- @@ -43,10 +39,20 @@ object Main extends Logging { def main(args:

[GitHub] spark pull request: [SPARK-11845][Streaming][Test] Added unit test...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9831#discussion_r45382352 --- Diff: core/src/test/scala/org/apache/spark/CheckpointSuite.scala --- @@ -21,17 +21,222 @@ import java.io.File import scala.reflect.ClassTag

[GitHub] spark pull request: [SPARK-11689] [ML] Add user guide and example ...

2015-11-19 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/9722#discussion_r45382273 --- Diff: docs/ml-guide.md --- @@ -40,6 +40,7 @@ Also, some algorithms have additional capabilities in the `spark.ml` API; e.g., provide class

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9796#discussion_r45384135 --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala --- @@ -395,8 +395,8 @@ class

[GitHub] spark pull request: [SPARK-11789] [core] [yarn] Lower severity of ...

2015-11-19 Thread vanzin
Github user vanzin commented on the pull request: https://github.com/apache/spark/pull/9780#issuecomment-158159573 @andrewor14 yes, I was actually looking for that bug instead of filing a new one, but couldn't find it. I'll update things. --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-11789] [core] [yarn] Lower severity of ...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9780#issuecomment-158159448 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-10086] [PySpark] [MLlib] [Streaming] [T...

2015-11-19 Thread BryanCutler
Github user BryanCutler commented on the pull request: https://github.com/apache/spark/pull/9670#issuecomment-158160419 Thanks for the response @mengxr. I tried setting the following: `@volatile protected var model: StreamingKMeansModel = new StreamingKMeansModel(null, null)`

[GitHub] spark pull request: [SPARK-11789] [core] [yarn] Lower severity of ...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9780#issuecomment-158162370 **[Test build #46342 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46342/consoleFull)** for PR 9780 at commit

[GitHub] spark pull request: [SPARK-11334] numRunningTasks can't be less th...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9288#discussion_r45386808 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -615,7 +615,11 @@ private[spark] class ExecutorAllocationManager(

[GitHub] spark pull request: [SPARK-6521][Core] Bypass unnecessary network ...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9478#issuecomment-158169482 @maropu any updates? Did you have a chance to do the benchmarks? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-11140] [core] Transfer files using netw...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9530#issuecomment-158179685 **[Test build #46349 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46349/consoleFull)** for PR 9530 at commit

[GitHub] spark pull request: [SPARK-11703] [Docker] Fix spark-mesos Dockerf...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9301#issuecomment-158147997 By the way, maybe this should be changed to 1.6.0 now. Then we need to backport whatever fix we have here into the 1.5 branch. --- If your project is set up for it,

[GitHub] spark pull request: [WIP] [SPARK-11327] [MESOS] Dispatcher does no...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9752#issuecomment-158149585 Yes, @jayv would you mind opening this against the master branch? Then committers will decide which branches to put in when we merge. --- If your project is set up

[GitHub] spark pull request: [SPARK-11845][Streaming][Test] Added unit test...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9831#discussion_r45382443 --- Diff: core/src/test/scala/org/apache/spark/CheckpointSuite.scala --- @@ -21,17 +21,222 @@ import java.io.File import scala.reflect.ClassTag

[GitHub] spark pull request: [SPARK-11849][SQL] Analyzer should replace cur...

2015-11-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/9833#issuecomment-158153021 Merging this. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11831][Core][Tests]Use port 0 to avoid ...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9841#issuecomment-158158795 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11789] [core] [yarn] Lower severity of ...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9780#issuecomment-158158858 @vanzin does this overlap with https://issues.apache.org/jira/browse/SPARK-4134? --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-11831][Core][Tests]Use port 0 to avoid ...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9841#issuecomment-158158799 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11846] Add save/load for AFTSurvivalReg...

2015-11-19 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/9836#discussion_r45384357 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/IsotonicRegression.scala --- @@ -240,4 +254,61 @@ class IsotonicRegressionModel private[ml] (

[GitHub] spark pull request: [SPARK-8641][SQL] Native Spark Window function...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9819#issuecomment-158166159 **[Test build #46338 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46338/consoleFull)** for PR 9819 at commit

[GitHub] spark pull request: [SPARK-8641][SQL] Native Spark Window function...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9819#issuecomment-158166443 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-8641][SQL] Native Spark Window function...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9819#issuecomment-158166439 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

2015-11-19 Thread thunterdb
Github user thunterdb commented on the pull request: https://github.com/apache/spark/pull/9826#issuecomment-158169615 @mengxr with the fixes, the top menu breaks before the side menu :-) ![screen shot 2015-11-19 at 11 30 13

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

2015-11-19 Thread thunterdb
Github user thunterdb commented on the pull request: https://github.com/apache/spark/pull/9826#issuecomment-158169959 This is about as much as I can do with my very limited knowledge of CSS, so additional fixes can be done in a separate PR. --- If your project is set up for it, you

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9826#issuecomment-158172384 **[Test build #46343 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46343/consoleFull)** for PR 9826 at commit

[GitHub] spark pull request: [SPARK-11845][Streaming][Test] Added unit test...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9831#issuecomment-158153906 Looks fine. Just make the tests pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-6157][CORE] Unrolling with MEMORY_AND_D...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/4887#issuecomment-158161862 > if we call (1) after this line, it will release memory for other unrolled failed block. if we call (2), we can't got the specific memory for that MEMORY_AND_DISK

[GitHub] spark pull request: [SPARK-11858][SQL] Move sql.columnar into sql....

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9842#issuecomment-158172157 **[Test build #46344 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46344/consoleFull)** for PR 9842 at commit

[GitHub] spark pull request: [SPARK-11689] [ML] Add user guide and example ...

2015-11-19 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/9722#discussion_r45381957 --- Diff: docs/ml-clustering.md --- @@ -0,0 +1,31 @@ +--- +layout: global +title: Clustering - ML +displayTitle: ML - Clustering +---

[GitHub] spark pull request: [SPARK-11835] Adds a sidebar menu to MLlib's d...

2015-11-19 Thread thunterdb
Github user thunterdb commented on a diff in the pull request: https://github.com/apache/spark/pull/9826#discussion_r45381998 --- Diff: docs/_includes/nav-left-wrapper-ml.html --- @@ -0,0 +1,6 @@ + +ML --- End diff -- sure --- If your project is set up

[GitHub] spark pull request: [SPARK-11689] [ML] Add user guide and example ...

2015-11-19 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/9722#discussion_r45382669 --- Diff: examples/src/main/java/org/apache/spark/examples/ml/JavaLDAExample.java --- @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software

[GitHub] spark pull request: [SPARK-11845][Streaming][Test] Added unit test...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9831#discussion_r45382804 --- Diff: core/src/test/scala/org/apache/spark/CheckpointSuite.scala --- @@ -21,17 +21,222 @@ import java.io.File import scala.reflect.ClassTag

[GitHub] spark pull request: [SPARK-11689] [ML] Add user guide and example ...

2015-11-19 Thread feynmanliang
Github user feynmanliang commented on the pull request: https://github.com/apache/spark/pull/9722#issuecomment-158153601 LGTM after changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11845][Streaming][Test] Added unit test...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/9831#discussion_r45382679 --- Diff: streaming/src/test/scala/org/apache/spark/streaming/rdd/TrackStateRDDSuite.scala --- @@ -278,6 +287,50 @@ class TrackStateRDDSuite extends

[GitHub] spark pull request: [SPARK-11846] Add save/load for AFTSurvivalReg...

2015-11-19 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/9836#discussion_r45384012 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/IsotonicRegression.scala --- @@ -240,4 +254,61 @@ class IsotonicRegressionModel private[ml] (

[GitHub] spark pull request: [SPARK-11840] [SQL] Restore the 1.5's behavior...

2015-11-19 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/9828#issuecomment-158158186 OK. I am merging it to master and branch 1.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11334] numRunningTasks can't be less th...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9288#issuecomment-158168054 @XuTingjun A more robust way to do this may be to keep track of ``` private val stageIdToRunningTaskIds = new mutable.HashMap[Int, mutable.HashSet[Int]]

[GitHub] spark pull request: [SPARK-11858][SQL] Move sql.columnar into sql....

2015-11-19 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/9842 [SPARK-11858][SQL] Move sql.columnar into sql.execution. In addition, tightened visibility of a lot of classes in the columnar package from private[sql] to private[columnar]. You can merge this pull

[GitHub] spark pull request: [SPARK-10766][SPARK-SUBMIT]Add some configurat...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/8918#issuecomment-158172457 I still don't see why it's necessary to change the class path of the client. If you're using Spark with HBase you should change the driver / executor classpaths, not

[GitHub] spark pull request: [SPARK-11831][Core][Tests]Use port 0 to avoid ...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9841#issuecomment-158152446 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-11689] [ML] Add user guide and example ...

2015-11-19 Thread feynmanliang
Github user feynmanliang commented on a diff in the pull request: https://github.com/apache/spark/pull/9722#discussion_r45382120 --- Diff: docs/ml-clustering.md --- @@ -0,0 +1,31 @@ +--- +layout: global +title: Clustering - ML +displayTitle: ML - Clustering +---

[GitHub] spark pull request: [SPARK-11821] Propagate Kerberos keytab for al...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9837#issuecomment-158154158 @woj-i please open the patch against the master branch instead. Committers will backport it into branch-1.5 when they merge it. --- If your project is set up for

[GitHub] spark pull request: [SPARK-11821] Propagate Kerberos keytab for al...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9837#issuecomment-158154058 @tgravescs @harishreedharan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9796#issuecomment-158156689 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-11831][Core][Tests]Use port 0 to avoid ...

2015-11-19 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9841#issuecomment-158159773 retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...

2015-11-19 Thread dskrvk
Github user dskrvk commented on the pull request: https://github.com/apache/spark/pull/9696#issuecomment-158163207 Jenkins, retest this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11829] [ML] Add read/write to estimator...

2015-11-19 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/9838#discussion_r45396273 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala --- @@ -432,9 +432,9 @@ class Word2Vec extends Serializable with Logging {

[GitHub] spark pull request: [SPARK-11584][SQL] The attribute of temporay t...

2015-11-19 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/9588#issuecomment-158190433 This kind of discussion should happen on JIRA. Briefly, temporary tables are just pointers to a logical plan (similar to a view that is temporary to the session).

[GitHub] spark pull request: [SPARK-11812] [PySpark] invFunc=None works pro...

2015-11-19 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/9775#issuecomment-158191955 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request: [SPARK-11633] [SQL] LogicalRDD throws TreeNode...

2015-11-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9762 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11778] [SQL]:parse table name before it...

2015-11-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9773 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-11789] [core] [yarn] Lower severity of ...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9780#issuecomment-158199248 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11867] Add save/load for kmeans and nai...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9849#issuecomment-158234543 **[Test build #46371 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46371/consoleFull)** for PR 9849 at commit

[GitHub] spark pull request: [SPARK-11846] Add save/load for AFTSurvivalReg...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9836#issuecomment-158235753 **[Test build #46370 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46370/consoleFull)** for PR 9836 at commit

[GitHub] spark pull request: [SPARK-11761] Prevent the call to StreamingCon...

2015-11-19 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9741#issuecomment-158237731 Should we do this in `SparkContext` as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11275][SQL] Rollup and Cube Generates t...

2015-11-19 Thread gatorsmile
Github user gatorsmile commented on the pull request: https://github.com/apache/spark/pull/9419#issuecomment-158237648 Thank you everyone! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-11831][Core][Tests]Use port 0 to avoid ...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9850#issuecomment-158237775 [Test build #46372 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46372/consoleFull) for PR 9850 at commit

[GitHub] spark pull request: [SPARK-11781][SPARKR] SparkR has problem in in...

2015-11-19 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/9769#discussion_r45419720 --- Diff: R/pkg/R/DataFrame.R --- @@ -717,25 +717,30 @@ setMethod("collect", # data of complex type can be held. But getting a cell

[GitHub] spark pull request: [SPARK-4134] [core] Lower severity of some exe...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9780#issuecomment-158238466 **[Test build #46355 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46355/consoleFull)** for PR 9780 at commit

[GitHub] spark pull request: Prevent the call to SparkContext#stop() in the...

2015-11-19 Thread tedyu
GitHub user tedyu opened a pull request: https://github.com/apache/spark/pull/9852 Prevent the call to SparkContext#stop() in the listener bus's thread This is continuation of SPARK-11761 Andrew suggested adding this protection. See tail of

[GitHub] spark pull request: [SPARK-11867] Add save/load for kmeans and nai...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9849#issuecomment-158242082 **[Test build #46371 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46371/consoleFull)** for PR 9849 at commit

[GitHub] spark pull request: [SPARK-11867] Add save/load for kmeans and nai...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9849#issuecomment-158242191 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11867] Add save/load for kmeans and nai...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9849#issuecomment-158242190 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11846] Add save/load for AFTSurvivalReg...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9836#issuecomment-158243929 **[Test build #46370 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46370/consoleFull)** for PR 9836 at commit

[GitHub] spark pull request: [SPARK-11846] Add save/load for AFTSurvivalReg...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9836#issuecomment-158244036 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11845][Streaming][Test] Added unit test...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9831#issuecomment-158243888 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-11845][Streaming][Test] Added unit test...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9831#issuecomment-158243889 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-11864] [SQL] Improve performance of max...

2015-11-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/9846#issuecomment-158244525 **[Test build #46358 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46358/consoleFull)** for PR 9846 at commit

[GitHub] spark pull request: [SPARK-11864] [SQL] Improve performance of max...

2015-11-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9846#issuecomment-158244665 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

<    1   2   3   4   5   6   7   >