[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

2016-07-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13981 **[Test build #61628 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61628/consoleFull)** for PR 13981 at commit

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r69343465 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -652,6 +656,129 @@ case class

[GitHub] spark issue #14016: [SPARK-15761] [FOLLOWUP] Set DEFAULT_PYTHON to python

2016-07-01 Thread MechCoder
Github user MechCoder commented on the issue: https://github.com/apache/spark/pull/14016 @srowen fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark issue #14016: [SPARK-15761] [FOLLOWUP] Set DEFAULT_PYTHON to python

2016-07-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14016 **[Test build #61632 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61632/consoleFull)** for PR 14016 at commit

[GitHub] spark issue #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor port rest...

2016-07-01 Thread drcrallen
Github user drcrallen commented on the issue: https://github.com/apache/spark/pull/11157 How would I set a JMX port or debug port with this approach? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #13861: [SPARK-15885] [Web UI] Provide links to executor logs fr...

2016-07-01 Thread tmagrino
Github user tmagrino commented on the issue: https://github.com/apache/spark/pull/13861 I had to black out a few hostnames to avoid NDA issues with my clusters, but the format should be clear.

[GitHub] spark issue #13980: [SPARK-16198] [MLlib] [ML] Change access level of predic...

2016-07-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13980 **[Test build #61631 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61631/consoleFull)** for PR 13980 at commit

[GitHub] spark issue #14017: [MINOR][BUILD] Fix Java linter errors

2016-07-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/14017 Thank you for review, @srowen :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13980: [SPARK-16198] [MLlib] [ML] Change access level of predic...

2016-07-01 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/13980 Jenkins test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] spark issue #13980: [SPARK-16198] [MLlib] [ML] Change access level of predic...

2016-07-01 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/13980 I can't OK this, but can test it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #14017: [MINOR][BUILD] Fix Java linter errors

2016-07-01 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/14017 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] spark pull request #14016: [SPARK-15761] [FOLLOWUP] Set DEFAULT_PYTHON to py...

2016-07-01 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/14016#discussion_r69341904 --- Diff: bin/pyspark --- @@ -31,12 +31,7 @@ export _SPARK_CMD_USAGE="Usage: ./bin/pyspark [options]" # and executor Python executables. #

[GitHub] spark issue #9207: [SPARK-11171][SPARK-11237][SPARK-11241][ML] Try adding PM...

2016-07-01 Thread holdenk
Github user holdenk commented on the issue: https://github.com/apache/spark/pull/9207 @MLnick I like that idea! I've done the shortcut approach on the root (since thats the shortcut we already had) - but I'll look at adding the shortcut on the MLWriter its self as well. Thanks! ---

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-01 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69341032 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,233 @@ private[mesos] trait

[GitHub] spark issue #13861: [SPARK-15885] [Web UI] Provide links to executor logs fr...

2016-07-01 Thread ajbozarth
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/13861 If you could attach new screen shots please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark issue #13980: [SPARK-16198] [MLlib] [ML] Change access level of predic...

2016-07-01 Thread husseinhazimeh
Github user husseinhazimeh commented on the issue: https://github.com/apache/spark/pull/13980 @srowen can you please have a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-01 Thread skonto
Github user skonto commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69340420 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,233 @@ private[mesos] trait

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-01 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69340374 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,233 @@ private[mesos] trait

[GitHub] spark issue #13861: [SPARK-15885] [Web UI] Provide links to executor logs fr...

2016-07-01 Thread tmagrino
Github user tmagrino commented on the issue: https://github.com/apache/spark/pull/13861 Latest commit now uses the more minimalist format discussed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark issue #13704: [SPARK-15985][SQL] Reduce runtime overhead of a program ...

2016-07-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13704 **[Test build #61630 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61630/consoleFull)** for PR 13704 at commit

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-01 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69339697 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,233 @@ private[mesos] trait

[GitHub] spark issue #13704: [SPARK-15985][SQL] Reduce runtime overhead of a program ...

2016-07-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13704 **[Test build #61629 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61629/consoleFull)** for PR 13704 at commit

[GitHub] spark issue #13704: [SPARK-15985][SQL] Reduce runtime overhead of a program ...

2016-07-01 Thread kiszk
Github user kiszk commented on the issue: https://github.com/apache/spark/pull/13704 @cloud-fan, I checked the following >Let me check which code portion inserts Cast in this tree. IIUC, [this

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-01 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69338825 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,233 @@ private[mesos] trait

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-01 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69338924 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,233 @@ private[mesos] trait

[GitHub] spark issue #14011: [SparkR] [Doc] SparkR ML user guides update for 2.0

2016-07-01 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/14011 looks good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-01 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69338665 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerUtils.scala --- @@ -356,4 +374,233 @@ private[mesos] trait

[GitHub] spark issue #13950: [SPARK-15487] [Web UI] Spark Master UI to reverse proxy ...

2016-07-01 Thread ajbozarth
Github user ajbozarth commented on the issue: https://github.com/apache/spark/pull/13950 @srowen @zsxwing @tgravescs What do you guys think of @gurvindersingh proposal? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

2016-07-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13981 **[Test build #61628 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61628/consoleFull)** for PR 13981 at commit

[GitHub] spark issue #13984: [SPARK-16310][SPARKR] R na.string-like default for csv s...

2016-07-01 Thread felixcheung
Github user felixcheung commented on the issue: https://github.com/apache/spark/pull/13984 @shivaram what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark issue #13981: [SPARK-16307] [ML] Add test to verify the predicted vari...

2016-07-01 Thread MechCoder
Github user MechCoder commented on the issue: https://github.com/apache/spark/pull/13981 @sethah Thank you for your comments. I have addressed them. Do you have anything else? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-01 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69337156 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -423,18 +432,35 @@ private[spark]

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-01 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69336408 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -423,18 +432,35 @@ private[spark]

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-01 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69336174 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -423,18 +432,35 @@ private[spark]

[GitHub] spark pull request #11157: [SPARK-11714][Mesos] Make Spark on Mesos honor po...

2016-07-01 Thread mgummelt
Github user mgummelt commented on a diff in the pull request: https://github.com/apache/spark/pull/11157#discussion_r69335697 --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala --- @@ -423,18 +432,35 @@ private[spark]

[GitHub] spark issue #14016: [SPARK-15761] [FOLLOWUP] Set DEFAULT_PYTHON to python

2016-07-01 Thread MechCoder
Github user MechCoder commented on the issue: https://github.com/apache/spark/pull/14016 Thanks for clarifying! It might be a good time to get rid of it.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #13951: [WIP][SPARK-8425]

2016-07-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13951 **[Test build #61627 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61627/consoleFull)** for PR 13951 at commit

[GitHub] spark pull request #13981: [SPARK-16307] [ML] Add test to verify the predict...

2016-07-01 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/13981#discussion_r69333966 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/DecisionTreeRegressorSuite.scala --- @@ -96,6 +108,15 @@ class DecisionTreeRegressorSuite

[GitHub] spark issue #14017: [MINOR][BUILD] Fix Java linter errors

2016-07-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14017 **[Test build #61626 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61626/consoleFull)** for PR 14017 at commit

[GitHub] spark issue #13976: [SPARK-16288][SQL] Implement inline table generating fun...

2016-07-01 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/13976 no problem... sorry i had to kill it, but i wanted to get a quick jenkins restart in. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark issue #13976: [SPARK-16288][SQL] Implement inline table generating fun...

2016-07-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13976 Thank you, @shaneknapp ! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] spark pull request #14017: [MINOR][BUILD] Fix Java linter errors

2016-07-01 Thread dongjoon-hyun
GitHub user dongjoon-hyun opened a pull request: https://github.com/apache/spark/pull/14017 [MINOR][BUILD] Fix Java linter errors ## What changes were proposed in this pull request? This PR fixes the minor Java linter errors like the following. ``` -public int

[GitHub] spark issue #14016: [SPARK-15761] [FOLLOWUP] Set DEFAULT_PYTHON to python

2016-07-01 Thread JoshRosen
Github user JoshRosen commented on the issue: https://github.com/apache/spark/pull/14016 If I recall, the original motivation for preferring the `python2.7` executable to plain `python` was that `python` might be Python 2.6 on older CentOS / RHEL systems and certain parts of PySpark

[GitHub] spark pull request #13981: [SPARK-16307] [ML] Add test to verify the predict...

2016-07-01 Thread MechCoder
Github user MechCoder commented on a diff in the pull request: https://github.com/apache/spark/pull/13981#discussion_r69332114 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/DecisionTreeRegressorSuite.scala --- @@ -96,6 +108,15 @@ class DecisionTreeRegressorSuite

[GitHub] spark issue #14007: [SPARK-16329] [SQL] Star Expansion over Table Containing...

2016-07-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14007 **[Test build #61625 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61625/consoleFull)** for PR 14007 at commit

[GitHub] spark issue #13976: [SPARK-16288][SQL] Implement inline table generating fun...

2016-07-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13976 **[Test build #61624 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61624/consoleFull)** for PR 13976 at commit

[GitHub] spark issue #14016: [SPARK-15761] [FOLLOWUP] Set DEFAULT_PYTHON to python

2016-07-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14016 **[Test build #61623 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61623/consoleFull)** for PR 14016 at commit

[GitHub] spark issue #13976: [SPARK-16288][SQL] Implement inline table generating fun...

2016-07-01 Thread shaneknapp
Github user shaneknapp commented on the issue: https://github.com/apache/spark/pull/13976 jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark issue #14016: [SPARK-15761] [FOLLOWUP] Set DEFAULT_PYTHON to python

2016-07-01 Thread MechCoder
Github user MechCoder commented on the issue: https://github.com/apache/spark/pull/14016 ping @srowen @JoshRosen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request #14016: [SPARK-15761] [FOLLOWUP] Set DEFAULT_PYTHON to py...

2016-07-01 Thread MechCoder
GitHub user MechCoder opened a pull request: https://github.com/apache/spark/pull/14016 [SPARK-15761] [FOLLOWUP] Set DEFAULT_PYTHON to python ## What changes were proposed in this pull request? I would like to change ```bash if hash python2.7 2>/dev/null; then

[GitHub] spark issue #14007: [SPARK-16329] [SQL] Star Expansion over Table Containing...

2016-07-01 Thread gatorsmile
Github user gatorsmile commented on the issue: https://github.com/apache/spark/pull/14007 @maropu Sure, let me resolve it. Thanks for catching it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request #14007: [SPARK-16329] [SQL] Star Expansion over Table Con...

2016-07-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14007#discussion_r69329991 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala --- @@ -215,6 +215,8 @@ abstract class Star extends

[GitHub] spark issue #14007: [SPARK-16329] [SQL] Star Expansion over Table Containing...

2016-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14007 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61621/ Test FAILed. ---

[GitHub] spark issue #14007: [SPARK-16329] [SQL] Star Expansion over Table Containing...

2016-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/14007 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #14007: [SPARK-16329] [SQL] Star Expansion over Table Containing...

2016-07-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14007 **[Test build #61621 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61621/consoleFull)** for PR 14007 at commit

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13680 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13680 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61620/ Test PASSed. ---

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-07-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13680 **[Test build #61620 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61620/consoleFull)** for PR 13680 at commit

[GitHub] spark pull request #14004: [SPARK-16285][SQL] Implement sentences SQL functi...

2016-07-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14004#discussion_r69325521 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -801,6 +804,49 @@ public static UTF8String

[GitHub] spark pull request #14004: [SPARK-16285][SQL] Implement sentences SQL functi...

2016-07-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/14004#discussion_r69325407 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -801,6 +804,49 @@ public static UTF8String

[GitHub] spark issue #13976: [SPARK-16288][SQL] Implement inline table generating fun...

2016-07-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13976 Thank you, @cloud-fan . I renovated ugly testcases with `create_row()`! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark issue #13976: [SPARK-16288][SQL] Implement inline table generating fun...

2016-07-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13976 **[Test build #61622 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61622/consoleFull)** for PR 13976 at commit

[GitHub] spark issue #13953: [SPARK-16265][SUBMIT] Addition of --driver-jre Flag to S...

2016-07-01 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/13953 See comments in the JIRA, including mine. I do not think this is in scope for Spark or worth maintaining and troubleshooting. --- If your project is set up for it, you can reply to this email and

[GitHub] spark issue #13834: [SPARK-16339] [CORE] ScriptTransform does not print stde...

2016-07-01 Thread srowen
Github user srowen commented on the issue: https://github.com/apache/spark/pull/13834 OK, I guess that's a safe enough assumption. I guess I'm worried just because we've seen that if this doesn't happen then waitFor will hang. But I suppose there's no reason to expect it would block

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-01 Thread janplus
Github user janplus commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r69323801 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala --- @@ -725,4 +725,43 @@ class

[GitHub] spark issue #13953: [SPARK-16265][SUBMIT] Addition of --driver-jre Flag to S...

2016-07-01 Thread andreweduffy
Github user andreweduffy commented on the issue: https://github.com/apache/spark/pull/13953 @petermaxlee can you give an example of how it can "get into a lot of problems"? The use case seems weird if you're usually developing on hardware that you control, but makes more sense if

[GitHub] spark pull request #13976: [SPARK-16288][SQL] Implement inline table generat...

2016-07-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13976#discussion_r69321672 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala --- @@ -195,3 +195,42 @@ case class Explode(child:

[GitHub] spark issue #13962: [SPARK-16095][YARN] Yarn cluster mode should report corr...

2016-07-01 Thread renozhang
Github user renozhang commented on the issue: https://github.com/apache/spark/pull/13962 @vanzin I've updated codes and comments. Please take a look, thanks a lot. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request #13976: [SPARK-16288][SQL] Implement inline table generat...

2016-07-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/13976#discussion_r69321184 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/generators.scala --- @@ -195,3 +195,42 @@ case class Explode(child:

[GitHub] spark issue #13967: [SPARK-16278][SPARK-16279][SQL] Implement map_keys/map_v...

2016-07-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13967 Hi, @cloud-fan . Could you merge this PR? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` optimize...

2016-07-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue: https://github.com/apache/spark/pull/13906 Thank you for merging, @liancheng , @cloud-fan , and @rxin . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark issue #14007: [SPARK-16329] [SQL] Star Expansion over Table Containing...

2016-07-01 Thread maropu
Github user maropu commented on the issue: https://github.com/apache/spark/pull/14007 Great work! One question; I got weird results from this fix. ``` scala> case class DATA(a: Int) defined class DATA scala> val df1 = Seq(DATA(1)).toDF df1:

[GitHub] spark issue #14007: [SPARK-16329] [SQL] Star Expansion over Table Containing...

2016-07-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/14007 **[Test build #61621 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61621/consoleFull)** for PR 14007 at commit

[GitHub] spark pull request #14007: [SPARK-16329] [SQL] Star Expansion over Table Con...

2016-07-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/14007#discussion_r69319196 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala --- @@ -215,6 +215,8 @@ abstract class Star extends

[GitHub] spark issue #13962: [SPARK-16095][YARN] Yarn cluster mode should report corr...

2016-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13962 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61619/ Test PASSed. ---

[GitHub] spark issue #13962: [SPARK-16095][YARN] Yarn cluster mode should report corr...

2016-07-01 Thread AmplabJenkins
Github user AmplabJenkins commented on the issue: https://github.com/apache/spark/pull/13962 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark issue #13962: [SPARK-16095][YARN] Yarn cluster mode should report corr...

2016-07-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13962 **[Test build #61619 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61619/consoleFull)** for PR 13962 at commit

[GitHub] spark issue #14009: [SPARK-16311][SQL] Metadata refresh should work on tempo...

2016-07-01 Thread liancheng
Github user liancheng commented on the issue: https://github.com/apache/spark/pull/14009 LGTM except for a minor styling issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request #14009: [SPARK-16311][SQL] Metadata refresh should work o...

2016-07-01 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/14009#discussion_r69316671 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/MetadataCacheSuite.scala --- @@ -77,12 +77,12 @@ class MetadataCacheSuite extends QueryTest with

[GitHub] spark pull request #13925: [SPARK-16226][SQL]change the way of JDBC commit

2016-07-01 Thread lihongliustc
Github user lihongliustc closed the pull request at: https://github.com/apache/spark/pull/13925 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark issue #13680: [SPARK-15962][SQL] Introduce implementation with a dense...

2016-07-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13680 **[Test build #61620 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61620/consoleFull)** for PR 13680 at commit

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-01 Thread janplus
Github user janplus commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r69314031 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -653,6 +657,125 @@ case class

[GitHub] spark issue #13962: [SPARK-16095][YARN] Yarn cluster mode should report corr...

2016-07-01 Thread SparkQA
Github user SparkQA commented on the issue: https://github.com/apache/spark/pull/13962 **[Test build #61619 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61619/consoleFull)** for PR 13962 at commit

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r69309179 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -653,6 +657,125 @@ case class

[GitHub] spark pull request #14007: [SPARK-16329] [SQL] Star Expansion over Table Con...

2016-07-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14007#discussion_r69307924 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala --- @@ -215,6 +215,8 @@ abstract class Star extends

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-01 Thread janplus
Github user janplus commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r69307883 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala --- @@ -725,4 +725,43 @@ class

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-01 Thread janplus
Github user janplus commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r69307503 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -653,6 +657,125 @@ case class

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-01 Thread janplus
Github user janplus commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r69307232 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -653,6 +657,125 @@ case class

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-01 Thread janplus
Github user janplus commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r69307187 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -653,6 +657,125 @@ case class

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-01 Thread janplus
Github user janplus commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r69307094 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -653,6 +657,125 @@ case class

[GitHub] spark issue #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` optimize...

2016-07-01 Thread liancheng
Github user liancheng commented on the issue: https://github.com/apache/spark/pull/13906 Merged to master. @cloud-fan Sorry that I didn't notice your comment while merging it. We may address it in follow-up ones. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` o...

2016-07-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13906 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request #14004: [SPARK-16285][SQL] Implement sentences SQL functi...

2016-07-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14004#discussion_r69305302 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -801,6 +804,49 @@ public static UTF8String concatWs(UTF8String

[GitHub] spark pull request #13906: [SPARK-16208][SQL] Add `PropagateEmptyRelation` o...

2016-07-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13906#discussion_r69304216 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/PropagateEmptyRelation.scala --- @@ -0,0 +1,78 @@ +/* + * Licensed

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r69303124 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala --- @@ -725,4 +725,43 @@ class

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r69302923 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -653,6 +657,125 @@ case class

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r69302808 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -653,6 +657,125 @@ case class

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r69302506 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -653,6 +657,125 @@ case class

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r69302511 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -653,6 +657,125 @@ case class

[GitHub] spark pull request #14008: [SPARK-16281][SQL] Implement parse_url SQL functi...

2016-07-01 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/14008#discussion_r69302431 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -653,6 +657,125 @@ case class

<    1   2   3   4   5   >