Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/12601#discussion_r69267347
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCRelation.scala
---
@@ -96,7 +97,16 @@ private[sql] case class
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14008
Hi, @janplus .
I've done first pass.
Thank you for doing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69266712
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala
---
@@ -725,4 +725,43 @@ class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14002
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61604/
Test FAILed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14002
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14002
**[Test build #61604 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61604/consoleFull)**
for PR 14002 at commit
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13374#discussion_r69266623
--- Diff: python/pyspark/sql/readwriter.py ---
@@ -745,6 +748,8 @@ def csv(self, path, mode=None, compression=None,
sep=None, quote=None, escape=No
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13374#discussion_r69266538
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
---
@@ -366,6 +366,32 @@ class CSVSuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69266491
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala ---
@@ -226,6 +226,20 @@ class StringFunctionsSuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69266465
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala ---
@@ -226,6 +226,20 @@ class StringFunctionsSuite extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69266361
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala
---
@@ -725,4 +725,43 @@ class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69266407
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala ---
@@ -226,6 +226,20 @@ class StringFunctionsSuite extends
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13503
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69266296
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala
---
@@ -725,4 +725,43 @@ class
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/13503
Merged to master/2.0/1.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69266113
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala
---
@@ -725,4 +725,43 @@ class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69265722
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala
---
@@ -725,4 +725,43 @@ class
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13973
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/13973
Merged to master/2.0. I went ahead with this as I think it's a reasonably
important fix for something that only manifests in Java 8, that we hard-kill
executors and don't let them for example finish
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69265591
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -653,6 +655,128 @@ case class
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/13906
Hi, @rxin , @cloud-fan , @liancheng . It's ready for merging again.
Thank you so much for being together with this PR!
---
If your project is set up for it, you can reply to this email
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14011
**[Test build #61606 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61606/consoleFull)**
for PR 14011 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14011
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14011
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61606/
Test PASSed.
---
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69264464
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -653,6 +655,128 @@ case class
Github user janplus commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69264274
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -653,6 +655,128 @@ case class
Github user janplus commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69264025
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -653,6 +655,128 @@ case class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69263681
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -653,6 +655,128 @@ case class
Github user janplus commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69263461
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -653,6 +655,128 @@ case class
Github user janplus commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69263441
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -653,6 +655,128 @@ case class
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/13957
this looks good for scala, please add the java and python.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/13957#discussion_r69263155
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/streaming/StructuredNetworkWordCountWindowed.scala
---
@@ -0,0 +1,102 @@
+/*
+ *
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/13957#discussion_r69262951
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/streaming/StructuredNetworkWordCountWindowed.scala
---
@@ -0,0 +1,102 @@
+/*
+ *
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69262783
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -653,6 +655,128 @@ case class
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/14011
cc @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13998
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69262363
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -653,6 +655,128 @@ case class
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/13957#discussion_r69262396
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/streaming/StructuredNetworkWordCountWindowed.scala
---
@@ -0,0 +1,102 @@
+/*
+ *
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14009
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14009
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61600/
Test PASSed.
---
Github user tdas commented on the issue:
https://github.com/apache/spark/pull/13998
Merging this to master and 2.0. Will keep monitoring the test flakiness.
Thank you very much @koeninger
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14009
**[Test build #61600 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61600/consoleFull)**
for PR 14009 at commit
Github user lihongliustc commented on the issue:
https://github.com/apache/spark/pull/13925
@srowen Thanks.I will close the PR.And I will try my best to do something
like @gatorsmile said.Thanks to every participant.
---
If your project is set up for it, you can reply to this email
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14009
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61599/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14009
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14009
**[Test build #61599 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61599/consoleFull)**
for PR 14009 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14011
**[Test build #61606 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61606/consoleFull)**
for PR 14011 at commit
GitHub user yanboliang opened a pull request:
https://github.com/apache/spark/pull/14011
[SparkR] [Doc] SparkR ML user guides update for 2.0
## What changes were proposed in this pull request?
Update SparkR ML section.
Since #13972 adds labelling support for the
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69260667
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -653,6 +655,128 @@ case class
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13834
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13834
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61602/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13834
**[Test build #61602 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61602/consoleFull)**
for PR 13834 at commit
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/14008
Oh. Sure. @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14009
LGTM except a minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14009#discussion_r69259865
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -462,17 +462,15 @@ class SessionCatalog(
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/13834
Hm, but now the stream is not closed in the case of an exception. I think
we have a Utils method for closing and logging any exception that occurs? that
would let it then proceed anyway
---
If
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13906
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13906
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61598/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13906
**[Test build #61598 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61598/consoleFull)**
for PR 13906 at commit
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/14010
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13998
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61596/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13998
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13998
**[Test build #61596 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61596/consoleFull)**
for PR 13998 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13957
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61597/
Test PASSed.
---
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/13957
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13957
**[Test build #61597 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61597/consoleFull)**
for PR 13957 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14002
**[Test build #61605 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61605/consoleFull)**
for PR 14002 at commit
Github user lianhuiwang commented on the issue:
https://github.com/apache/spark/pull/13494
@cloud-fan Thanks. I will look at it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14002
**[Test build #61604 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61604/consoleFull)**
for PR 14002 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13982
**[Test build #3160 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3160/consoleFull)**
for PR 13982 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14010
**[Test build #61603 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61603/consoleFull)**
for PR 14010 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13989
**[Test build #3159 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3159/consoleFull)**
for PR 13989 at commit
GitHub user WeichenXu123 opened a pull request:
https://github.com/apache/spark/pull/14010
[GRAPHX][EXAMPLES] move graphx test data directory and update graphx
document
## What changes were proposed in this pull request?
There are two test data for graphx examples which
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14002
**[Test build #3157 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3157/consoleFull)**
for PR 14002 at commit
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14002
**[Test build #3158 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3158/consoleFull)**
for PR 14002 at commit
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/13957#discussion_r69254704
--- Diff:
examples/src/main/scala/org/apache/spark/examples/sql/streaming/StructuredNetworkWordCountWindowed.scala
---
@@ -0,0 +1,102 @@
+/*
+ *
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14006
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61601/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14006
**[Test build #61601 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61601/consoleFull)**
for PR 14006 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14006
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14007
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/61595/
Test PASSed.
---
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/13834
**[Test build #61602 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61602/consoleFull)**
for PR 13834 at commit
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14007
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14007
**[Test build #61595 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61595/consoleFull)**
for PR 14007 at commit
Github user tejasapatil commented on the issue:
https://github.com/apache/spark/pull/13834
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user renozhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/13962#discussion_r69253594
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala ---
@@ -287,19 +330,19 @@ private object YarnClusterDriver extends
Github user renozhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/13962#discussion_r69253305
--- Diff:
yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnClusterSuite.scala ---
@@ -330,9 +373,6 @@ private object YarnClusterDriver extends Logging
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14008#discussion_r69253202
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -653,6 +655,128 @@ case class StringRPad(str:
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14006
**[Test build #61601 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61601/consoleFull)**
for PR 14006 at commit
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/13993
The change looks good for me. For the ```summary``` issue, I left comments
at JIRA.
cc @mengxr for another pass. Thanks!
---
If your project is set up for it, you can reply to this email
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14009
**[Test build #61600 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/61600/consoleFull)**
for PR 14009 at commit
401 - 490 of 490 matches
Mail list logo
